Open Diman119 opened 1 year ago
Tested this on an Acer Swift XSFX14-41G running Fedora 38. Module continued to work and was persistent through a kernel update.
For Fedora, you'd need to install the following at a minimum: sudo dnf group install "C Development Tools and Libraries" "Development Tools" sudo dnf install kernel-devel dkms
Tested on Acer Aspire 7 A715-42G and Ubuntu 23.04. It seems work flawless.
Working on Acer Nitro AN515-57, thank you for this PR!
@Diman119
The PR repo doesn't accept issues, so putting it here. Somehow the module didn't work 4 days after I installed it in DKMS. Using lsmod it seems to be loaded:
I tried uninstalling and installing it again and got this (in Pop!_OS):
The value went back to 0 after 2 days for no apparent reason.
No problem with DKMS:
Also no problem in lsmod:
I don't think this problem comes from the PR, maybe the base repository has some bug that reverts this value back to 0.
Just remembered to update on comments above. I fixed it by adding a systemd service to force health_mode to be 1 on startup. I have no experience with building drivers but maybe to fix this it would be needed to persist this value in a file and get that file on reboot/kernel updates.
@Diman119
The PR repo doesn't accept issues, so putting it here. Somehow the module didn't work 4 days after I installed it in DKMS. Using lsmod it seems to be loaded:
I tried uninstalling and installing it again and got this (in Pop!_OS):
I do not know how the driver actually works, so I can't help you there, but there indeed was a problem with the uninstall script. The script is now fixed, pull the changes and use the new one if you want a cleaner uninstallation.
Added a persistent installation script, that does 2 things - installs the module into the kernel with DKMS (and makes it survive kernel upgrades) and sets it to load at boot. Added an uninstallation script, that reverts these actions. Tested on Ubuntu 23.04