search

frederik-hoeft / rimworld-more-injuries

0 stars 0 forks source link

Mod incompatibilities and other bugs #1

Open Mullymuffinman opened 1 week ago

Mullymuffinman commented 1 week ago

Hi!

some of the current mod incompatibilites seem to be:

Body parts added by other mods, - Will upload try to edit or create seperate issue when i have the logs for this one.

Black screen world generation/failing due to incompatibilities In map bug causing menu "back to main menu" to fail

I have added the mods that seem to clash here: Hospitality, Survival Tools, Animal Tab,

VFE - seems to have an issue with the abilities modifier Unsure if "From Ashes to Ashes, Dust to Dust" mod also effected

I have added the the log i received here:

Log 1: Could not get load ID. We're asking for something which was never added during LoadingVars. pathRelToParent=/shoppingArea, parent=Human174189 UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch7 (string) Verse.LoadIDsWantedBank:Take (string,Verse.IExposable) Verse.CrossRefHandler:TakeResolvedRef (string,Verse.IExposable) Verse.CrossRefHandler:TakeResolvedRef (string) Verse.Scribe_References:Look (Verse.Area&,string,bool) Hospitality.CompGuest:PostExposeData () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ThingWithComps.ExposeData_Patch2 (Verse.ThingWithComps) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Pawn.ExposeData_Patch9 (Verse.Pawn) Verse.CrossRefHandler:ResolveAllCrossReferences () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ScribeLoader.FinalizeLoading_Patch1 (Verse.ScribeLoader) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.LoadGame_Patch12 (Verse.Game) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.SavedGameLoaderNow.LoadGameFromSaveFileNow_Patch7 (string) Verse.Root_Play/<>c:b__1_1 () Verse.LongEventHandler:RunEventFromAnotherThread (System.Action) Verse.LongEventHandler/<>c:b__28_0 () System.Threading.ThreadHelper:ThreadStart_Context (object) System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object) System.Threading.ThreadHelper:ThreadStart ()

Log 2: Could not get load ID. We're asking for something which was never added during LoadingVars. pathRelToParent=/bed, parent=Human174189 UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch7 (string) Verse.LoadIDsWantedBank:Take (string,Verse.IExposable) Verse.CrossRefHandler:TakeResolvedRef (string,Verse.IExposable) Verse.CrossRefHandler:TakeResolvedRef (string) Verse.Scribe_References:Look (Hospitality.Building_GuestBed&,string,bool) Hospitality.CompGuest:PostExposeData () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ThingWithComps.ExposeData_Patch2 (Verse.ThingWithComps) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Pawn.ExposeData_Patch9 (Verse.Pawn) Verse.CrossRefHandler:ResolveAllCrossReferences () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ScribeLoader.FinalizeLoading_Patch1 (Verse.ScribeLoader) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.LoadGame_Patch12 (Verse.Game) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.SavedGameLoaderNow.LoadGameFromSaveFileNow_Patch7 (string) Verse.Root_Play/<>c:b__1_1 () Verse.LongEventHandler:RunEventFromAnotherThread (System.Action) Verse.LongEventHandler/<>c:b__28_0 () System.Threading.ThreadHelper:ThreadStart_Context (object) System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object) System.Threading.ThreadHelper:ThreadStart ()

Log 3: Could not get load ID. We're asking for something which was never added during LoadingVars. pathRelToParent=/curSurvivalToolAssignment, parent=Human174189 UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch7 (string) Verse.LoadIDsWantedBank:Take (string,Verse.IExposable) Verse.CrossRefHandler:TakeResolvedRef (string,Verse.IExposable) Verse.CrossRefHandler:TakeResolvedRef (string) Verse.Scribe_References:Look (SurvivalTools.SurvivalToolAssignment&,string,bool) SurvivalTools.Pawn_SurvivalToolAssignmentTracker:PostExposeData () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ThingWithComps.ExposeData_Patch2 (Verse.ThingWithComps) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Pawn.ExposeData_Patch9 (Verse.Pawn) Verse.CrossRefHandler:ResolveAllCrossReferences () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ScribeLoader.FinalizeLoading_Patch1 (Verse.ScribeLoader) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.LoadGame_Patch12 (Verse.Game) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.SavedGameLoaderNow.LoadGameFromSaveFileNow_Patch7 (string) Verse.Root_Play/<>c:b__1_1 () Verse.LongEventHandler:RunEventFromAnotherThread (System.Action) Verse.LongEventHandler/<>c:b__28_0 () System.Threading.ThreadHelper:ThreadStart_Context (object) System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object) System.Threading.ThreadHelper:ThreadStart ()

Log 4: Could not get load ID. We're asking for something which was never added during LoadingVars. pathRelToParent=/deadlifeDustFaction, parent=Human174189 UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch7 (string) Verse.LoadIDsWantedBank:Take (string,Verse.IExposable) Verse.CrossRefHandler:TakeResolvedRef (string,Verse.IExposable) Verse.CrossRefHandler:TakeResolvedRef (string) Verse.Scribe_References:Look (RimWorld.Faction&,string,bool) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Pawn.ExposeData_Patch9 (Verse.Pawn) Verse.CrossRefHandler:ResolveAllCrossReferences () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ScribeLoader.FinalizeLoading_Patch1 (Verse.ScribeLoader) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.LoadGame_Patch12 (Verse.Game) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.SavedGameLoaderNow.LoadGameFromSaveFileNow_Patch7 (string) Verse.Root_Play/<>c:b__1_1 () Verse.LongEventHandler:RunEventFromAnotherThread (System.Action) Verse.LongEventHandler/<>c:b__28_0 () System.Threading.ThreadHelper:ThreadStart_Context (object) System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object) System.Threading.ThreadHelper:ThreadStart ()

Log 5: Could not get load ID. We're asking for something which was never added during LoadingVars. pathRelToParent=/animalTab.handler.pawn, parent=Human177846 UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch7 (string) Verse.LoadIDsWantedBank:Take (string,Verse.IExposable) Verse.CrossRefHandler:TakeResolvedRef (string,Verse.IExposable) Verse.CrossRefHandler:TakeResolvedRef (string) Verse.Scribe_References:Look (Verse.Pawn&,string,bool) AnimalTab.CompHandlerSettings:PostExposeData () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ThingWithComps.ExposeData_Patch2 (Verse.ThingWithComps) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Pawn.ExposeData_Patch9 (Verse.Pawn) Verse.CrossRefHandler:ResolveAllCrossReferences () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ScribeLoader.FinalizeLoading_Patch1 (Verse.ScribeLoader) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.LoadGame_Patch12 (Verse.Game) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.SavedGameLoaderNow.LoadGameFromSaveFileNow_Patch7 (string) Verse.Root_Play/<>c:b__1_1 () Verse.LongEventHandler:RunEventFromAnotherThread (System.Action) Verse.LongEventHandler/<>c:b__28_0 () System.Threading.ThreadHelper:ThreadStart_Context (object) System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object) System.Threading.ThreadHelper:ThreadStart ()

Log 6: Could not get load ID. We're asking for something which was never added during LoadingVars. pathRelToParent=/currentlyCasting, parent=Human177846 UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch7 (string) Verse.LoadIDsWantedBank:Take (string,Verse.IExposable) Verse.CrossRefHandler:TakeResolvedRef (string,Verse.IExposable) Verse.CrossRefHandler:TakeResolvedRef (string) Verse.Scribe_References:Look (VFECore.Abilities.Ability&,string,bool) VFECore.Abilities.CompAbilities:PostExposeData () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ThingWithComps.ExposeData_Patch2 (Verse.ThingWithComps) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Pawn.ExposeData_Patch9 (Verse.Pawn) Verse.CrossRefHandler:ResolveAllCrossReferences () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ScribeLoader.FinalizeLoading_Patch1 (Verse.ScribeLoader) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.LoadGame_Patch12 (Verse.Game) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.SavedGameLoaderNow.LoadGameFromSaveFileNow_Patch7 (string) Verse.Root_Play/<>c:b__1_1 () Verse.LongEventHandler:RunEventFromAnotherThread (System.Action) Verse.LongEventHandler/<>c:b__28_0 () System.Threading.ThreadHelper:ThreadStart_Context (object) System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object) System.Threading.ThreadHelper:ThreadStart ()

log 7: Could not get load ID. We're asking for something which was never added during LoadingVars. pathRelToParent=/guestArea, parent=Human177846 UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch7 (string) Verse.LoadIDsWantedBank:Take (string,Verse.IExposable) Verse.CrossRefHandler:TakeResolvedRef (string,Verse.IExposable) Verse.CrossRefHandler:TakeResolvedRef (string) Verse.Scribe_References:Look (Verse.Area&,string,bool) Hospitality.CompGuest:PostExposeData () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ThingWithComps.ExposeData_Patch2 (Verse.ThingWithComps) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Pawn.ExposeData_Patch9 (Verse.Pawn) Verse.CrossRefHandler:ResolveAllCrossReferences () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ScribeLoader.FinalizeLoading_Patch1 (Verse.ScribeLoader) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.LoadGame_Patch12 (Verse.Game) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.SavedGameLoaderNow.LoadGameFromSaveFileNow_Patch7 (string) Verse.Root_Play/<>c:b__1_1 () Verse.LongEventHandler:RunEventFromAnotherThread (System.Action) Verse.LongEventHandler/<>c:b__28_0 () System.Threading.ThreadHelper:ThreadStart_Context (object) System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object) System.Threading.ThreadHelper:ThreadStart ()

On load in - This is the only log i wasn't sure if was related to your mod or not, so it may be irrelevant [HugsLib][ERR] Quickstart aborted: errors detected in log UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch7 (string) HugsLib.Utils.ModLogger:Error (string,object[]) HugsLib.Quickstart.QuickstartController:InitiateQuickstart () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.LongEventHandler.UpdateCurrentSynchronousEvent_Patch2 (bool&) Verse.LongEventHandler:LongEventsUpdate (bool&) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Root.Update_Patch1 (Verse.Root) Verse.Root_Entry:Update ()

Mullymuffinman commented 1 week ago

I dont know if this tells you anything but this is the error i get upon map generation with the pawn. I wasnt able to repeat the body parts bug. yet. If not relevant please disregard.

Log 1: Soyuz caught this error. Please don't report this to the RocketMan team unless you're certain RocketMan caused this error. with error System.IndexOutOfRangeException: Index was outside the bounds of the array. [Ref 52928CBF] at Verse.AI.PathFinder.FindPath (Verse.IntVec3 start, Verse.LocalTargetInfo dest, Verse.TraverseParms traverseParms, Verse.AI.PathEndMode peMode, Verse.AI.PathFinderCostTuning tuning) [0x009bc] in <2a40c3593b334f29ac3cb3d32d652351>:0

Log 2: Exception ticking Poinmoinkag (at (144, 0, 131)): System.IndexOutOfRangeException: Index was outside the bounds of the array. [Ref 25DB234F] at Verse.AI.PathFinder.FindPath (Verse.IntVec3 start, Verse.LocalTargetInfo dest, Verse.TraverseParms traverseParms, Verse.AI.PathEndMode peMode, Verse.AI.PathFinderCostTuning tuning) [0x009bc] in <2a40c3593b334f29ac3cb3d32d652351>:0

frederik-hoeft commented 1 week ago

Thanks for the logs and Feedback! 😄 More Injuries had some save file incompatibilities when adding it to existing saves. That has been fixed now with the latest Steam update (Could not get load ID. ...)

As for the other stack traces, I'm not sure if they are related. A safe indication would be if MoreInjuries appears somewhere in the stack trace or if there is a different mod that works fine by itself, but causes reproducible exceptions when paired with More Injuries. When running RimWorld with a large mod pack, it's sometimes very difficult to say what exactly goes wrong where; especially when there are a lot of transpiler patches, and especially if one mod has minor side effects that break invariants and assumptions made by another mod author 😓

Now, as far as I can tell, your second bug reports are related to path finding which I would suspect could be an issue between CleanPathfinding and CAI not working so well together, or it could just be an issue in CleanPathfinding. I can with relative safety say that More Injuries isn't related with that.

The other logs (the very first ones) are some load issues caused by something - might be related, might not be 🤔 What exactly were you doing when those log entries came? (saving or loading and existing save? did that save already have More Injuries loaded, or did you add More Injuries afterwards?

Does your mod pack work fine without More Injuries or are there already issues?

Mullymuffinman commented 1 week ago

Yea for sure, for sure. These were however the errors that popped up when the mod was added to the already rather extensive mod pack i have. Yes my current modpack does genuinly run smoothly. Im not going to say it runs completly bug free / there are some events that bug out and for example having pawns without certain needs in "Nature's Pretty Sweet" gives a spam error when pawns are in the hot&cold springs and drowning somehow doesn't seem to go beyond a certain level. Overall though ive only reported the new errors i've found and fatal errors. There is 1 biomesKit error in log on startup but not on generation of new game or load of saves in my current modpack - i've been debugging it for a while :').

One thing i've found with the current version is that i seem to get this log on startup which i find interesting:

[HugsLib][ERR] Quickstart aborted: errors detected in log UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch7 (string) HugsLib.Utils.ModLogger:Error (string,object[]) HugsLib.Quickstart.QuickstartController:InitiateQuickstart () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.LongEventHandler.UpdateCurrentSynchronousEvent_Patch2 (bool&) Verse.LongEventHandler:LongEventsUpdate (bool&) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Root.Update_Patch1 (Verse.Root) Verse.Root_Entry:Update () THIS LOG TURNED OUT TO BE IRRELEVANT TO More Injuries

I'll try it again now with the new version and report back if Ifind some more reproducible errors :) Yea, i appreciate the insight.

The logs were produced upon startup and loading of an existing save. I'll get back to you if there are more errors. If you hear nothing assume it works 👍

Mullymuffinman commented 1 week ago

So unfortunately Trying to load the current save with More injuries added is still incompatible and does not load.

For current save load following More injury log added:

Log 1 

Could not do PostLoadInit on Mata: System.NullReferenceException: Object reference not set to an instance of an object
[Ref 50214EFA]
 at Verse.Pawn.get_InAggroMentalState () [0x00008] in <2a40c3593b334f29ac3cb3d32d652351>:0 
 at RimWorld.Pawn_GuiltTracker.get_IsGuilty () [0x00009] in <2a40c3593b334f29ac3cb3d32d652351>:0 
 at Stranger_Danger.CustomMethods.PawnCheck (Verse.Pawn pawn) [0x000af] in <30902e262e3f47a088d3560bc767face>:0 
 at Stranger_Danger.CustomMethods.ShouldHide (Verse.Pawn pawn, Stranger_Danger.CustomMethods+HideType hideType) [0x0002d] in <30902e262e3f47a088d3560bc767face>:0 
 at Stranger_Danger.PawnLabelHoverPatch.LabelNoCountPatch (Verse.Pawn __instance, System.String& __result) [0x0001f] in <30902e262e3f47a088d3560bc767face>:0 
 at Verse.Pawn.get_LabelNoCount () [0x000a7] in <2a40c3593b334f29ac3cb3d32d652351>:0 
     - POSTFIX com.vanillageneticrimexpanded: Void GeneticRim.Patch_PawnLabel:Postfix(Pawn __instance, String& __result)
     - POSTFIX StrangerDangerPatch: Void Stranger_Danger.PawnLabelHoverPatch:LabelNoCountPatch(Pawn __instance, String& __result)
 at Verse.Thing.get_Label () [0x00025] in <2a40c3593b334f29ac3cb3d32d652351>:0 
 **at MoreInjuries.Patches.Patch_Pawn_ExposeData.Postfix (Verse.Pawn __instance) [0x00135] in <687c515cfb254411a9fb28f72c6bac91>:0** 
 at Verse.Pawn.ExposeData () [0x006bb] in <2a40c3593b334f29ac3cb3d32d652351>:0 
     - POSTFIX ReSpliceCoreMod: Void ReSpliceCore.Pawn_ExposeData_Patch:Postfix(Pawn __instance)
     - POSTFIX VanillaExpanded.VFEA: Void VFEAncients.Pawn_PowerTracker:Save(Pawn __instance)
     - POSTFIX VanillaExpanded.VFEA: Void VFEAncients.HarmonyPatches.MetaMorphPatches:SaveMetamorphed(Pawn __instance)
     - POSTFIX rimworld.smartkar.enhancedbeliefs.main: Void EnhancedBeliefs.Pawn_ExposeData:Postfix(Pawn __instance)
     - POSTFIX Th3Fr3d.MoreInjuries: Void MoreInjuries.Patches.Patch_Pawn_ExposeData:Postfix(Pawn __instance)
     - POSTFIX VanillaVehiclesExpanded.Mod: Void VanillaVehiclesExpanded.Pawn_ExposeData_Patch:Postfix(Pawn __instance)
     - POSTFIX rimworld.TechBackground: Void TechBackground.Pawn_ExposeData:Postfix(Pawn __instance)
     - POSTFIX kathanon.ImpressionableChildren: Void ImpressionableChildren.Learning_Patches:ExposeData(Pawn& __instance)
     - POSTFIX Harmony_PrisonLabor: Void PrisonLabor.HarmonyPatches.Patches_RenamingPrisoners.Patch_RenamePrisoners+SaveOldName:Postfix(Pawn __instance)
     - POSTFIX ReSpliceCoreMod: Void ReSpliceCore.Pawn_ExposeData_Patch:Postfix(Pawn __instance)
 at Verse.PostLoadIniter.DoAllPostLoadInits () [0x00032] in <2a40c3593b334f29ac3cb3d32d652351>:0 
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch7 (string)
Verse.PostLoadIniter:DoAllPostLoadInits ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ScribeLoader.FinalizeLoading_Patch1 (Verse.ScribeLoader)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.LoadGame_Patch12 (Verse.Game)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.SavedGameLoaderNow.LoadGameFromSaveFileNow_Patch7 (string)
Verse.Root_Play/<>c:<Start>b__1_1 ()
Verse.LongEventHandler:RunEventFromAnotherThread (System.Action)
Verse.LongEventHandler/<>c:<UpdateCurrentAsynchronousEvent>b__28_0 ()
System.Threading.ThreadHelper:ThreadStart_Context (object)
System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object)
System.Threading.ThreadHelper:ThreadStart ()

Log 2 - Exists for many differnt body parts, i.e arm, clavicle, finger, radius, waist

Tried to add health diff to missing part BodyPartRecord(Humerus parts.Count=0)
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch7 (string)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.HediffSet.AddDirect_Patch8 (Verse.HediffSet,Verse.Hediff,System.Nullable`1<Verse.DamageInfo>,Verse.DamageWorker/DamageResult)
MSE2.BackCompatibility.HediffClassLoading:ReinstallWrongClassed (Verse.HediffSet)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.HediffSet.ExposeData_Patch2 (Verse.HediffSet)
Verse.CrossRefHandler:ResolveAllCrossReferences ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ScribeLoader.FinalizeLoading_Patch1 (Verse.ScribeLoader)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.LoadGame_Patch12 (Verse.Game)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.SavedGameLoaderNow.LoadGameFromSaveFileNow_Patch7 (string)
Verse.Root_Play/<>c:<Start>b__1_1 ()
Verse.LongEventHandler:RunEventFromAnotherThread (System.Action)
Verse.LongEventHandler/<>c:<UpdateCurrentAsynchronousEvent>b__28_0 ()
System.Threading.ThreadHelper:ThreadStart_Context (object)
System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object)
System.Threading.ThreadHelper:ThreadStart ()

I am given an extra me the following error Log:

UnloadedWorldObjectComp(parent=Settlement Terrell (tile=54039) at=54039) :: Have 0 unloaded pawns. 
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Message_Patch1 (string)
FactionManager.UnloadedWorldObjectComp:PostExposeData ()
RimWorld.Planet.WorldObject:ExposeData ()
RimWorld.Planet.MapParent:ExposeData ()
RimWorld.Planet.Settlement:ExposeData ()
Verse.CrossRefHandler:ResolveAllCrossReferences ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ScribeLoader.FinalizeLoading_Patch1 (Verse.ScribeLoader)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.LoadGame_Patch12 (Verse.Game)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.SavedGameLoaderNow.LoadGameFromSaveFileNow_Patch7 (string)
Verse.Root_Play/<>c:<Start>b__1_1 ()
Verse.LongEventHandler:RunEventFromAnotherThread (System.Action)
Verse.LongEventHandler/<>c:<UpdateCurrentAsynchronousEvent>b__28_0 ()
System.Threading.ThreadHelper:ThreadStart_Context (object)
System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object)
System.Threading.ThreadHelper:ThreadStart ()

Now this seems to repeat for every single settlement included on the map. I'll try to create a new map and see if the problem repeats.

Yea so there is a mod incompatiblity somewhere still. Generation of new planets can't occur. I'll input the log when i can. So sad. I will try and sort through my mod list to see if i can find exactly what mod it is it clashes with but its definitely there, i had all kind of weird screen bugs and black scren bugs and what not in planet gerneration window for some reason and yea its still incompatible with my save file. Without works great though 😢 🤷

Is more Injuries compatible with Medical System Expansion 2?

Mullymuffinman commented 1 week ago

I got new planet generation working with a new map, with minimal errors. Im not sure why but the implementation of more injuries does somehow directly affect the loading and generation of the planet and map - meaning it goes into black screen. This is perhaps incompatiblities with other mods that interfere with body injuries and hediffs - like medical systems 2. I will continue to update with what i found but for now i have a semi stable build that i can use. And i find More injuries to be an essential part ✌️

sad. Upon trying to save game with Rimsaves the TPS freezes - game becomes frozen in place. No save is written although a saved message is displatyed

frederik-hoeft commented 1 week ago

So unfortunately Trying to load the current save with More injuries added is still incompatible and does not load.

For current save load following More injury log added:

Log 1

Could not do PostLoadInit on Mata: System.NullReferenceException: Object reference not set to an instance of an object
[Ref 50214EFA]
 at Verse.Pawn.get_InAggroMentalState () [0x00008] in <2a40c3593b334f29ac3cb3d32d652351>:0 
 at RimWorld.Pawn_GuiltTracker.get_IsGuilty () [0x00009] in <2a40c3593b334f29ac3cb3d32d652351>:0 
 at Stranger_Danger.CustomMethods.PawnCheck (Verse.Pawn pawn) [0x000af] in <30902e262e3f47a088d3560bc767face>:0 
 at Stranger_Danger.CustomMethods.ShouldHide (Verse.Pawn pawn, Stranger_Danger.CustomMethods+HideType hideType) [0x0002d] in <30902e262e3f47a088d3560bc767face>:0 
 at Stranger_Danger.PawnLabelHoverPatch.LabelNoCountPatch (Verse.Pawn __instance, System.String& __result) [0x0001f] in <30902e262e3f47a088d3560bc767face>:0 
 at Verse.Pawn.get_LabelNoCount () [0x000a7] in <2a40c3593b334f29ac3cb3d32d652351>:0 
     - POSTFIX com.vanillageneticrimexpanded: Void GeneticRim.Patch_PawnLabel:Postfix(Pawn __instance, String& __result)
     - POSTFIX StrangerDangerPatch: Void Stranger_Danger.PawnLabelHoverPatch:LabelNoCountPatch(Pawn __instance, String& __result)
 at Verse.Thing.get_Label () [0x00025] in <2a40c3593b334f29ac3cb3d32d652351>:0 
 **at MoreInjuries.Patches.Patch_Pawn_ExposeData.Postfix (Verse.Pawn __instance) [0x00135] in <687c515cfb254411a9fb28f72c6bac91>:0** 
 at Verse.Pawn.ExposeData () [0x006bb] in <2a40c3593b334f29ac3cb3d32d652351>:0 
     - POSTFIX ReSpliceCoreMod: Void ReSpliceCore.Pawn_ExposeData_Patch:Postfix(Pawn __instance)
     - POSTFIX VanillaExpanded.VFEA: Void VFEAncients.Pawn_PowerTracker:Save(Pawn __instance)
     - POSTFIX VanillaExpanded.VFEA: Void VFEAncients.HarmonyPatches.MetaMorphPatches:SaveMetamorphed(Pawn __instance)
     - POSTFIX rimworld.smartkar.enhancedbeliefs.main: Void EnhancedBeliefs.Pawn_ExposeData:Postfix(Pawn __instance)
     - POSTFIX Th3Fr3d.MoreInjuries: Void MoreInjuries.Patches.Patch_Pawn_ExposeData:Postfix(Pawn __instance)
     - POSTFIX VanillaVehiclesExpanded.Mod: Void VanillaVehiclesExpanded.Pawn_ExposeData_Patch:Postfix(Pawn __instance)
     - POSTFIX rimworld.TechBackground: Void TechBackground.Pawn_ExposeData:Postfix(Pawn __instance)
     - POSTFIX kathanon.ImpressionableChildren: Void ImpressionableChildren.Learning_Patches:ExposeData(Pawn& __instance)
     - POSTFIX Harmony_PrisonLabor: Void PrisonLabor.HarmonyPatches.Patches_RenamingPrisoners.Patch_RenamePrisoners+SaveOldName:Postfix(Pawn __instance)
     - POSTFIX ReSpliceCoreMod: Void ReSpliceCore.Pawn_ExposeData_Patch:Postfix(Pawn __instance)
 at Verse.PostLoadIniter.DoAllPostLoadInits () [0x00032] in <2a40c3593b334f29ac3cb3d32d652351>:0 
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch7 (string)
Verse.PostLoadIniter:DoAllPostLoadInits ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ScribeLoader.FinalizeLoading_Patch1 (Verse.ScribeLoader)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.LoadGame_Patch12 (Verse.Game)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.SavedGameLoaderNow.LoadGameFromSaveFileNow_Patch7 (string)
Verse.Root_Play/<>c:<Start>b__1_1 ()
Verse.LongEventHandler:RunEventFromAnotherThread (System.Action)
Verse.LongEventHandler/<>c:<UpdateCurrentAsynchronousEvent>b__28_0 ()
System.Threading.ThreadHelper:ThreadStart_Context (object)
System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object)
System.Threading.ThreadHelper:ThreadStart ()

Log 2 - Exists for many differnt body parts, i.e arm, clavicle, finger, radius, waist

Tried to add health diff to missing part BodyPartRecord(Humerus parts.Count=0)
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch7 (string)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.HediffSet.AddDirect_Patch8 (Verse.HediffSet,Verse.Hediff,System.Nullable`1<Verse.DamageInfo>,Verse.DamageWorker/DamageResult)
MSE2.BackCompatibility.HediffClassLoading:ReinstallWrongClassed (Verse.HediffSet)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.HediffSet.ExposeData_Patch2 (Verse.HediffSet)
Verse.CrossRefHandler:ResolveAllCrossReferences ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ScribeLoader.FinalizeLoading_Patch1 (Verse.ScribeLoader)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.LoadGame_Patch12 (Verse.Game)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.SavedGameLoaderNow.LoadGameFromSaveFileNow_Patch7 (string)
Verse.Root_Play/<>c:<Start>b__1_1 ()
Verse.LongEventHandler:RunEventFromAnotherThread (System.Action)
Verse.LongEventHandler/<>c:<UpdateCurrentAsynchronousEvent>b__28_0 ()
System.Threading.ThreadHelper:ThreadStart_Context (object)
System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object)
System.Threading.ThreadHelper:ThreadStart ()

I am given an extra me the following error Log:

UnloadedWorldObjectComp(parent=Settlement Terrell (tile=54039) at=54039) :: Have 0 unloaded pawns. 
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Message_Patch1 (string)
FactionManager.UnloadedWorldObjectComp:PostExposeData ()
RimWorld.Planet.WorldObject:ExposeData ()
RimWorld.Planet.MapParent:ExposeData ()
RimWorld.Planet.Settlement:ExposeData ()
Verse.CrossRefHandler:ResolveAllCrossReferences ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.ScribeLoader.FinalizeLoading_Patch1 (Verse.ScribeLoader)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.LoadGame_Patch12 (Verse.Game)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.SavedGameLoaderNow.LoadGameFromSaveFileNow_Patch7 (string)
Verse.Root_Play/<>c:<Start>b__1_1 ()
Verse.LongEventHandler:RunEventFromAnotherThread (System.Action)
Verse.LongEventHandler/<>c:<UpdateCurrentAsynchronousEvent>b__28_0 ()
System.Threading.ThreadHelper:ThreadStart_Context (object)
System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object)
System.Threading.ThreadHelper:ThreadStart ()

Now this seems to repeat for every single settlement included on the map. I'll try to create a new map and see if the problem repeats.

Yea so there is a mod incompatiblity somewhere still. Generation of new planets can't occur. I'll input the log when i can. So sad. I will try and sort through my mod list to see if i can find exactly what mod it is it clashes with but its definitely there, i had all kind of weird screen bugs and black scren bugs and what not in planet gerneration window for some reason and yea its still incompatible with my save file. Without works great though 😢 🤷

Is more Injuries compatible with Medical System Expansion 2?

Funnily enough #1 seems to crash because of logging 😅 and an apparent incompatibility with Stranger Danger https://github.com/frederik-hoeft/rimworld-more-injuries/blob/6aa808083d98c8d4295a2744b097fa5cc4eb9326/Source/MoreInjuries/MoreInjuries/Patches/Patch_Pawn_ExposeData.cs#L50 This should be an easy fix by calling into ToStringSafe() or by not displaying the pawn name in the warning message

2 seems indeed to be an incompatibility with Medical System Expansion 2. I'll try to reproduce the error and fix it in the new few days. Can you confirm that with just Stranger Danger, Medical System Expansion 2, and More Injuries loaded everything breaks? is it reproducible?

Not sure what #3 is about, but it could be a result of #1 and #2 🤔

Mullymuffinman commented 6 days ago

Hey man will give you some feedback on your comment later on, Will update comment later

It seems Melee animation is also affected, I'm assuming cause most of the More injuries functions is within drafted state. Not a log ive seen before:

Log1: [MeleeAnim] Gregor cannot reach target cell (253, 0, 65) to reach Shorty. UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Warning_Patch1 (string) AM.Core:Warn (string) AM.Jobs.JobDriver_GoToAnimationSpot/<>cDisplayClass5_0:g__MoveToTarget|0 (bool) AM.Jobs.JobDriver_GoToAnimationSpot/<>cDisplayClass5_0:b1 () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.AI.JobDriver.TryActuallyStartNextToil_Patch1 (Verse.AI.JobDriver) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.AI.JobDriver.ReadyForNextToil_Patch1 (Verse.AI.JobDriver) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.AI.Pawn_JobTracker.StartJob_Patch10 (Verse.AI.Pawn_JobTracker,Verse.AI.Job,Verse.AI.JobCondition,Verse.AI.ThinkNode,bool,bool,Verse.ThinkTreeDef,System.Nullable1<Verse.AI.JobTag>,bool,bool,System.Nullable1,bool,bool,bool) AM.UI.DraftedFloatMenuOptionsUI:ExecutionEnabledOnClick (Verse.Pawn,Verse.Pawn,AM.Controller.Reports.ExecutionAttemptReport,AM.Controller.Requests.ExecutionAttemptRequest) AM.UI.DraftedFloatMenuOptionsUI/<>c__DisplayClass9_0:b0 () Verse.FloatMenuOption:Chosen (bool,Verse.FloatMenu) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.FloatMenuOption.DoGUI_Patch1 (Verse.FloatMenuOption,UnityEngine.Rect,bool,Verse.FloatMenu) Verse.FloatMenu:DoWindowContents (UnityEngine.Rect) Verse.FloatMenuMap:DoWindowContents (UnityEngine.Rect) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Window.InnerWindowOnGUI_Patch0 (Verse.Window,int) UnityEngine.GUI:CallWindowDelegate (UnityEngine.GUI/WindowFunction,int,int,UnityEngine.GUISkin,int,single,single,UnityEngine.GUIStyle)

Log2: [MeleeAnim] CRITICAL ERROR: Failed to force interrupt Gregor's job with execution goto job. Likely a mod conflict or invalid start parameters. UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch7 (string) AM.Core:Error (string,System.Exception) AM.UI.DraftedFloatMenuOptionsUI:ExecutionEnabledOnClick (Verse.Pawn,Verse.Pawn,AM.Controller.Reports.ExecutionAttemptReport,AM.Controller.Requests.ExecutionAttemptRequest) AM.UI.DraftedFloatMenuOptionsUI/<>c__DisplayClass9_0:b__0 () Verse.FloatMenuOption:Chosen (bool,Verse.FloatMenu) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.FloatMenuOption.DoGUI_Patch1 (Verse.FloatMenuOption,UnityEngine.Rect,bool,Verse.FloatMenu) Verse.FloatMenu:DoWindowContents (UnityEngine.Rect) Verse.FloatMenuMap:DoWindowContents (UnityEngine.Rect) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Window.InnerWindowOnGUI_Patch0 (Verse.Window,int) UnityEngine.GUI:CallWindowDelegate (UnityEngine.GUI/WindowFunction,int,int,UnityEngine.GUISkin,int,single,single,UnityEngine.GUIStyle)