search

fredguile / ng2-md-datatable

Angular 5+ DataTable component for using with Material Design 2
https://www.npmjs.com/package/ng2-md-datatable
MIT License
38 stars 13 forks source link

bring table styles closer to the spec #5

Closed TitanNano closed 7 years ago

TitanNano commented 7 years ago

We changed the styles to be closer to the material spec.

TitanNano commented 7 years ago

@fredguile would you agree to merge this change? otherwise we need to publish our own package.

fredguile commented 7 years ago

Hi Jovan, thanks for your contribution! I'd be ok to merge it but I'm currently unable to reach any computer within 2 weeks :( Would you be ok to temporarily use your package during this time until I publish an update? I appreciate that you make this datatable even stronger. I can review your PR from my phone in the meantime.

m-s-sh commented 7 years ago

Just one more note, which I also added like a issue, in new material 2, md-color is mat-color. No matter what it is my favorite datatable!

fredguile commented 7 years ago

Except the minor comment I've made regarding the hover/selected color, many thanks for your contribution! I'll merge it and prepare a release with other additions very soon.