fredhicks / ehp-roll20

2 stars 0 forks source link

[Fate] Further Skill Range Expansion #2

Open jgkamat opened 1 year ago

jgkamat commented 1 year ago

Hello, and firstly, thanks for working on the fate sheet, it's one of my favorite sheets on roll20.

I'm planning on running a campaign with a heavily modified pyramid and skill limit - Ideally I would like to set the skill cap for the campaign to 20.

I noticed that unfortunately, raising the limit from 10 isn't trivial: https://github.com/Roll20/roll20-character-sheets/commit/66de44f6c53224d4ec8db722cfe1b811f4ef244e

I understand that it's not desirable to add so many extra lines to the SkillGridRating, but I wanted to see if we could get any increase in the limit. Maybe it would be possible to unbound the skills in compact list mode, or add a flat bonus to all rolls, or similar.

Any increase would be helpful for us, but I understand if this is something you won't be able to fix.

Thanks for taking a look!

fredhicks commented 1 year ago

Not easy at all I'm afraid. (Or rather, maybe not hard, but potentially time-consuming & in a very bloating-the-code sort of way.) I'll keep it on my "think about this" list, but there's only so far with customization that the code can anticipate & support.

I haven't poked at the sheet recently, but I wonder if you might be able to get at what you're after by creating the out-of-typical-bounds skill-like-things as very basic Extras, using that part of the sheet, rather than the skills part?

On Sun, Feb 12, 2023 at 3:17 PM Jay Kamat @.***> wrote:

Hello, and firstly, thanks for working on the fate sheet, it's one of my favorite sheets on roll20.

I'm planning on running a campaign with a heavily modified pyramid and skill limit - Ideally I would like to set the skill cap for the campaign to 20.

I noticed that unfortunately, raising the limit from 10 isn't trivial: @.*** https://github.com/Roll20/roll20-character-sheets/commit/66de44f6c53224d4ec8db722cfe1b811f4ef244e

I understand that it's not desirable to add so many extra lines to the SkillGridRating, but I wanted to see if we could get any increase in the limit. Maybe it would be possible to unbound the skills in compact list mode, or add a flat bonus to all rolls, or similar.

Any increase would be helpful for us, but I understand if this is something you won't be able to fix.

Thanks for taking a look!

— Reply to this email directly, view it on GitHub https://github.com/fredhicks/ehp-roll20/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB46UFFGCNUDRZJGS4LCDM3WXFAM3ANCNFSM6AAAAAAUZRJDBU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

Fred HicksEvil Hat Productions, LLC www.evilhat.com FYI: My replies tend to be terse and direct to the point in the interests of efficiency (I get tons of email daily); if that comes off as rude, my apologies, it's not my intention!

jgkamat commented 1 year ago

Fred Hicks writes:

I haven't poked at the sheet recently, but I wonder if you might be able to get at what you're after by creating the out-of-typical-bounds skill-like-things as very basic Extras, using that part of the sheet, rather than the skills part?

Ah, thanks for this pointer, I think this works for us! The only minor issue is that the value can't be "scrolled" above 10, you need to enter it manually. But once you do, things look good. Unfortunately there's not really a way to remove the other fields fully - but this should work for us.

Thanks for the pointer! -Jay

jgkamat commented 1 year ago

I also just discovered through experimenting some more, that if you set Display Style-> compact list, and type in the skill value, it seems to be set. Through the other display style, it dosen't seem to save above 10.

It dosen't seem to display correctly in the UI, but it seems to be handled correctly for rolls.

Hopefully that can help anyone else who has the same issue. 1676495461 1676495457

fredhicks commented 1 year ago

Ah yes, I forgot! The compact display can just straightforwardly present the data. Getting the other format to display the data requires creating a bunch of fields and dynamically loading the data into those fields so it can all be displayed properly. So, yeah — if you're good running with Compact List, the engine should function.

On Wed, Feb 15, 2023 at 4:11 PM Jay Kamat @.***> wrote:

I also just discovered through experimenting some more, that if you set Display Style-> compact list, and type in the skill value, it seems to be set. Through the other display style, it dosen't seem to save above 10.

It dosen't seem to display correctly in the UI, but it seems to be handled correctly for rolls.

Hopefully that can help anyone else who has the same issue. [image: 1676495461] https://user-images.githubusercontent.com/4349709/219164697-5c7fb789-9cb7-4b1e-bd78-49fe3b265341.png [image: 1676495457] https://user-images.githubusercontent.com/4349709/219164704-e5d914f3-d351-4121-9866-3e34005f77aa.png

— Reply to this email directly, view it on GitHub https://github.com/fredhicks/ehp-roll20/issues/2#issuecomment-1432038953, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB46UFALC6SK6QIR7HE4ZPLWXVBA5ANCNFSM6AAAAAAUZRJDBU . You are receiving this because you commented.Message ID: @.***>

--

Fred HicksEvil Hat Productions, LLC www.evilhat.com FYI: My replies tend to be terse and direct to the point in the interests of efficiency (I get tons of email daily); if that comes off as rude, my apologies, it's not my intention!