search

fredizzimo / infinity_ergodox

Unofficial keyboard firmware for Input Club's Infinity Ergodox
GNU General Public License v2.0
61 stars 16 forks source link

There's no LED support #5

Open fredizzimo opened 8 years ago

fredizzimo commented 8 years ago

I didn't solder LEDs to the keyboard myself so I'm unable to test and implement this feature myself. It shouldn't be hard to do, using the visualization framework.

If you either want to test or implement this, please contact me.

fredizzimo commented 8 years ago

Hm, that's very strange. I have to check what the problem could be.

If you want you can also try QMK, the changes were just merged, and the default layout should have the LEDs enabled.

To flash the keyboard you need to use make dfu-util

fredizzimo commented 8 years ago

@r2d2rogers, Have you tried re-plugging the keyboard a few times? Maybe the LEDs come only some of the times.

That's just guessing, but I really have no idea what's going on at the moment. And it also seems like the issue has been coming and going, with different versions. You can see that if your read the whole discussion in the issue.

I have never found a definite answer to the problem. But the fact that it seems to come and go, and stays constant over versions seems to indicate a memory corruption(unless you prove that theory wrong, by finding that it works some times and other times not) .

r2d2rogers commented 8 years ago

The LEDs haven't lit on multiple plug in attempts. I have tried direct to the PC, through the powered hub that has been working great so far, and one hand at a time. I have the QMK checked out and built on a linux machine, but I am on my Windows 10 workstation at work. I'm looking at the windows flash instructions for QMK (hex vs bin files) to attempt that next.

fredizzimo commented 8 years ago

@r2d2rogers,

If you run make dfu-util, it will automatically convert the elf to a bin file and flash it. If you can't flash on that machine, you can copy the generated bin file, and flash that on another machine.

r2d2rogers commented 8 years ago

Thank you, that's just what I needed to know.

It works. After I realized I forgot the master flag for which hand I plug into the computer. All LEDs working on QMK, with the fixed behavior of the LCD.

Looks like it's time to move over to the QMK for further issues.

fredizzimo commented 8 years ago

Great, although it doesn't really make sense that it works there, almost the same code should be used in both, which means that there's more debugging to be done...

Does the animation look right now?

And yes, the QMK port is starting to get ready. It already has basically all the features of this repository. The only thing missing are the unit tests, and the visualizing emulator.

I'm currently merging it with the EZ ergodox, so that all their keymaps can be used. And I also think I will make some improvements to the visualizer, before I will start recommending people to use that.

r2d2rogers commented 8 years ago

Actually, the LED animation isn't right, it's more of a fade in and out as a whole, not the ripple pattern.

Would me building with the MASTER=right flag affect the LED animation?

fredizzimo commented 8 years ago

I don't think it would.

I will soon have to go to bed, but tomorrow I will record a video of how it's supposed to look like. I can do that through the emulator, which renders everything on the PC. The emulator is a bit tricky to build though at the moment, so it's probably easier for me to make a video.

r2d2rogers commented 8 years ago

I pulled the most up to date version of the LED branch here and if I specify MASTER=right the LEDs in the keys do not light up. If I set it to left or don't specify anything (default left) they work correctly with good response from the layer display on the LCD when changing layers.

I will try right versus left on QMK and see what that does, but it will be later today.

fredizzimo commented 8 years ago

@r2d2rogers, thanks for the report. It will most likely be the same in QMK. It's probably an easy fix though.

And sorry, I completely forgot about the video, and can't do that until the weekend at the earliest. I'm at another computer right now, and I don't want to set it up for that.

r2d2rogers commented 8 years ago

I tried changing the submodules on the QMK to match what you are using here, but I still don't get more than the fade up and down on the LEDs on qmk, no rippling from edge to edge.

fredizzimo commented 8 years ago

I will check what's going on during the weekend.

r2d2rogers commented 8 years ago

Looks like we have the visualizer and LED stuff out of the loop on the latest versions of the QMK stuff. Is there anything I can poke at on getting the test stuff running with the latest sub-project modes? I now have two Infinity Ergodox sets at my disposal, so interating versions of the lighting while checking stability of the code is easy for me.

Currently I still have one set running the led branch here, and the other is on QMK with the subproject code for infinity ergodox.

fredizzimo commented 8 years ago

Hi @r2d2rogers,

Sorry for not answering earlier. Unfortunately I have been busy with https://github.com/jackhumbert/qmk_firmware/issues/591, but after that I will return to fixing the Visualizer.

The development speed is not that fast at the moment though, since I mostly have time only during the weekends, and maybe a few hours here and there during weekdays.