search

fredjk-gh / ObservatoryPlugins

A suite of plugins for Elite ObservatoryCore (https://github.com/Xjph/ObservatoryCore).
MIT License
7 stars 1 forks source link

Errors with old journal files #2

Closed DaftMav closed 1 year ago

DaftMav commented 1 year ago

When I use the 'Read All' button it gives a pop-up with 1028 errors: https://i.imgur.com/PT63paF.png

The error log is kinda big but it's mostly the same stuff, all from older journals, 2017-01 to 2019-05 so I think it's having some issues with a missing variable that was only added later to the Scan event in journal logs.

I suspect it's probably because old journals didn't have StarSystem yet, only BodyName on the Scan event. With the Observatory criteria we also have to check if scan.StarSystem is not nil so it doesn't break and all of the errors I'm getting here are "value cannot be null'. Might have to use the FSDJump event as that one does have StarSystem.

A portion of the error logs:

[28/03/2023 03:56:19]:
Error in Observatory Stat Scanner while handling Scan: Value cannot be null. (Parameter 'key') - { "timestamp":"2017-01-02T02:29:15Z", "event":"Scan", "BodyName":"Pleiades Sector AB-W b2-4", "DistanceFromArrivalLS":0.000000, "StarType":"M", "StellarMass":0.363281, "Radius":372561984.000000, "AbsoluteMagnitude":8.924423, "Age_MY":11990, "SurfaceTemperature":3076.000000, "RotationPeriod":181078.250000 }

[28/03/2023 03:56:19]:
Error in Observatory Stat Scanner while handling Scan: Value cannot be null. (Parameter 'key') - { "timestamp":"2017-01-02T17:38:25Z", "event":"Scan", "BodyName":"Taurus Dark Region EL-Y d16", "DistanceFromArrivalLS":0.000000, "StarType":"K", "StellarMass":0.773438, "Radius":609963328.000000, "AbsoluteMagnitude":5.577957, "Age_MY":358, "SurfaceTemperature":5194.000000, "RotationPeriod":273326.312500 }

[28/03/2023 03:56:19]:
Error in Observatory Stat Scanner while handling Scan: Value cannot be null. (Parameter 'key') - { "timestamp":"2017-01-02T20:09:37Z", "event":"Scan", "BodyName":"Maia A", "DistanceFromArrivalLS":0.000000, "StarType":"B", "StellarMass":13.617188, "Radius":1751272704.000000, "AbsoluteMagnitude":-1.480347, "Age_MY":564, "SurfaceTemperature":15569.000000, "SemiMajorAxis":17565050994688.000000, "Eccentricity":0.244384, "OrbitalInclination":26.209381, "Periapsis":253.923096, "OrbitalPeriod":150977527808.000000, "RotationPeriod":76926.765625 }

[28/03/2023 03:56:19]:
Error in Observatory Stat Scanner while handling Scan: Value cannot be null. (Parameter 'key') - { "timestamp":"2017-01-11T14:41:52Z", "event":"Scan", "BodyName":"Synuefe LJ-D b46-3 A", "DistanceFromArrivalLS":0.000000, "StarType":"M", "StellarMass":0.363281, "Radius":377571072.000000, "AbsoluteMagnitude":9.091873, "Age_MY":10720, "SurfaceTemperature":2940.000000, "SemiMajorAxis":470158442496.000000, "Eccentricity":0.034059, "OrbitalInclination":-24.680820, "Periapsis":116.592155, "OrbitalPeriod":707743744.000000, "RotationPeriod":221345.734375, "Rings":[ { "Name":"Synuefe LJ-D b46-3 A A Belt", "RingClass":"eRingClass_Rocky", "MassMT":5.0467e+13, "InnerRad":6.2299e+08, "OuterRad":1.8266e+09 } ] }

[28/03/2023 03:56:19]:
Error in Observatory Stat Scanner while handling Scan: Value cannot be null. (Parameter 'key') - { "timestamp":"2017-01-11T14:49:21Z", "event":"Scan", "BodyName":"Synuefe XR-H d11-102", "DistanceFromArrivalLS":0.000000, "StarType":"F", "StellarMass":1.394531, "Radius":909320384.000000, "AbsoluteMagnitude":3.468063, "Age_MY":3600, "SurfaceTemperature":6914.000000, "RotationPeriod":242894.984375, "Rings":[ { "Name":"Synuefe XR-H d11-102 A Belt", "RingClass":"eRingClass_MetalRich", "MassMT":1.0542e+17, "InnerRad":3.7421e+09, "OuterRad":1.5087e+11 } ] }

[28/03/2023 03:56:19]:
Error in Observatory Stat Scanner while handling Scan: Value cannot be null. (Parameter 'key') - { "timestamp":"2017-01-12T13:56:43Z", "event":"Scan", "BodyName":"Bakuari A", "DistanceFromArrivalLS":0.000000, "StarType":"M", "StellarMass":0.421875, "Radius":405269664.000000, "AbsoluteMagnitude":8.189407, "Age_MY":2536, "SurfaceTemperature":3493.000000, "SemiMajorAxis":18060173901824.000000, "Eccentricity":0.083527, "OrbitalInclination":16.137611, "Periapsis":44.723316, "OrbitalPeriod":718531723264.000000, "RotationPeriod":214354.109375, "Rings":[ { "Name":"Bakuari A A Belt", "RingClass":"eRingClass_MetalRich", "MassMT":8.9555e+13, "InnerRad":6.5174e+08, "OuterRad":1.8098e+09 } ] }

[28/03/2023 03:56:19]:
Error in Observatory Stat Scanner while handling Scan: Value cannot be null. (Parameter 'key') - { "timestamp":"2017-01-13T22:49:05Z", "event":"Scan", "BodyName":"133 G. Canis Major A", "DistanceFromArrivalLS":0.000000, "StarType":"A", "StellarMass":1.988281, "Radius":1148950400.000000, "AbsoluteMagnitude":2.907272, "Age_MY":422, "SurfaceTemperature":9477.000000, "SemiMajorAxis":26103676665856.000000, "Eccentricity":0.022947, "OrbitalInclination":103.582664, "Periapsis":248.058060, "OrbitalPeriod":259967893504.000000, "RotationPeriod":63778.375000 }

Journal with scans, just from the first error above (Pleiades Sector AB-W b2-4):

{ "timestamp":"2017-01-02T02:19:26Z", "event":"FSDJump", "StarSystem":"Pleiades Sector DB-X c1-11", "StarPos":[-129.563,-126.500,-366.625], "SystemAllegiance":"", "SystemEconomy":"$economy_None;", "SystemEconomy_Localised":"None", "SystemGovernment":"$government_None;", "SystemGovernment_Localised":"None", "SystemSecurity":"$SYSTEM_SECURITY_low;", "SystemSecurity_Localised":"Low Security", "JumpDist":15.467, "FuelUsed":1.395278, "FuelLevel":27.518007 }
{ "timestamp":"2017-01-02T02:19:54Z", "event":"FuelScoop", "Scooped":0.549885, "Total":28.067892 }
{ "timestamp":"2017-01-02T02:20:57Z", "event":"FSDJump", "StarSystem":"Pleiades Sector AB-W b2-4", "StarPos":[-137.563,-118.250,-380.438], "SystemAllegiance":"Empire", "SystemEconomy":"$economy_Military;", "SystemEconomy_Localised":"Military", "SystemGovernment":"$government_Patronage;", "SystemGovernment_Localised":"Patronage", "SystemSecurity":"$SYSTEM_SECURITY_medium;", "SystemSecurity_Localised":"Medium Security", "JumpDist":17.968, "FuelUsed":2.004683, "FuelLevel":26.063210, "SystemFaction":"Merope Expeditionary Fleet", "FactionState":"Investment" }
{ "timestamp":"2017-01-02T02:21:24Z", "event":"FuelScoop", "Scooped":0.788494, "Total":26.851704 }
{ "timestamp":"2017-01-02T02:22:05Z", "event":"Scan", "BodyName":"Pleiades Sector AB-W b2-4 1", "DistanceFromArrivalLS":166.711868, "TidalLock":true, "TerraformState":"", "PlanetClass":"Icy body", "Atmosphere":"", "Volcanism":"", "MassEM":0.015273, "Radius":2062772.625000, "SurfaceGravity":1.430622, "SurfaceTemperature":149.534454, "SurfacePressure":0.000000, "Landable":true, "Materials":{ "sulphur":23.3, "carbon":19.6, "iron":16.3, "phosphorus":12.5, "nickel":12.3, "chromium":7.3, "germanium":3.4, "zirconium":1.9, "cadmium":1.3, "tin":1.1, "yttrium":1.0 }, "SemiMajorAxis":49812275200.000000, "Eccentricity":0.010000, "OrbitalInclination":-0.674394, "Periapsis":110.270515, "OrbitalPeriod":10059159.000000, "RotationPeriod":10059162.000000 }
{ "timestamp":"2017-01-02T02:24:41Z", "event":"Scan", "BodyName":"Pleiades Sector AB-W b2-4 2", "DistanceFromArrivalLS":783.149048, "TidalLock":false, "TerraformState":"", "PlanetClass":"Rocky ice body", "Atmosphere":"methane atmosphere", "Volcanism":"", "MassEM":0.004226, "Radius":1241027.625000, "SurfaceGravity":1.093728, "SurfaceTemperature":115.527046, "SurfacePressure":30024.480469, "Landable":false, "SemiMajorAxis":234190192640.000000, "Eccentricity":0.002943, "OrbitalInclination":-0.370092, "Periapsis":260.039734, "OrbitalPeriod":102543984.000000, "RotationPeriod":77717.109375 }
{ "timestamp":"2017-01-02T02:29:15Z", "event":"Scan", "BodyName":"Pleiades Sector AB-W b2-4", "DistanceFromArrivalLS":0.000000, "StarType":"M", "StellarMass":0.363281, "Radius":372561984.000000, "AbsoluteMagnitude":8.924423, "Age_MY":11990, "SurfaceTemperature":3076.000000, "RotationPeriod":181078.250000 }
{ "timestamp":"2017-01-02T02:35:43Z", "event":"Scan", "BodyName":"Pleiades Sector AB-W b2-4 4", "DistanceFromArrivalLS":1962.099731, "TidalLock":true, "TerraformState":"", "PlanetClass":"Icy body", "Atmosphere":"", "Volcanism":"", "MassEM":0.004352, "Radius":1365665.000000, "SurfaceGravity":0.929956, "SurfaceTemperature":43.520565, "SurfacePressure":0.000000, "Landable":true, "Materials":{ "sulphur":23.3, "carbon":19.6, "iron":16.3, "phosphorus":12.5, "nickel":12.3, "chromium":7.3, "germanium":3.4, "zirconium":1.9, "cadmium":1.3, "molybdenum":1.1, "yttrium":1.0 }, "SemiMajorAxis":102843544.000000, "Eccentricity":0.161638, "OrbitalInclination":-1.412546, "Periapsis":232.627731, "OrbitalPeriod":10144981.000000, "RotationPeriod":14416514.000000 }
{ "timestamp":"2017-01-02T02:36:10Z", "event":"Scan", "BodyName":"Pleiades Sector AB-W b2-4 5", "DistanceFromArrivalLS":1961.338745, "TidalLock":false, "TerraformState":"", "PlanetClass":"Rocky ice body", "Atmosphere":"", "Volcanism":"", "MassEM":0.004269, "Radius":1245122.375000, "SurfaceGravity":1.097465, "SurfaceTemperature":43.520565, "SurfacePressure":0.000000, "Landable":true, "Materials":{ "sulphur":20.2, "iron":18.2, "carbon":17.0, "nickel":13.8, "phosphorus":10.9, "chromium":8.2, "manganese":7.5, "arsenic":1.7, "tin":1.2, "tungsten":1.0, "polonium":0.5 }, "SemiMajorAxis":104836592.000000, "Eccentricity":0.161638, "OrbitalInclination":-1.412546, "Periapsis":52.627720, "OrbitalPeriod":10144981.000000, "RotationPeriod":72246.148438 }
{ "timestamp":"2017-01-02T02:38:39Z", "event":"Scan", "BodyName":"Pleiades Sector AB-W b2-4 6", "DistanceFromArrivalLS":2653.413818, "TidalLock":false, "TerraformState":"", "PlanetClass":"Icy body", "Atmosphere":"", "Volcanism":"", "MassEM":0.004257, "Radius":1355832.625000, "SurfaceGravity":0.923028, "SurfaceTemperature":37.411533, "SurfacePressure":0.000000, "Landable":true, "Materials":{ "sulphur":22.1, "carbon":18.6, "iron":15.5, "phosphorus":11.9, "nickel":11.7, "chromium":7.0, "manganese":6.4, "vanadium":3.8, "cadmium":1.2, "ruthenium":1.0, "mercury":0.7 }, "SemiMajorAxis":211103776.000000, "Eccentricity":0.094402, "OrbitalInclination":-7.059708, "Periapsis":155.807571, "OrbitalPeriod":43402832.000000, "RotationPeriod":170946.531250 }
{ "timestamp":"2017-01-02T02:38:57Z", "event":"Scan", "BodyName":"Pleiades Sector AB-W b2-4 7", "DistanceFromArrivalLS":2653.819824, "TidalLock":false, "TerraformState":"", "PlanetClass":"Icy body", "Atmosphere":"", "Volcanism":"", "MassEM":0.002951, "Radius":1201510.250000, "SurfaceGravity":0.814776, "SurfaceTemperature":37.411533, "SurfacePressure":0.000000, "Landable":true, "Materials":{ "sulphur":23.3, "carbon":19.6, "iron":16.4, "phosphorus":12.5, "nickel":12.4, "chromium":7.4, "zinc":4.4, "arsenic":1.5, "niobium":1.1, "tungsten":0.9, "polonium":0.5 }, "SemiMajorAxis":304529856.000000, "Eccentricity":0.094402, "OrbitalInclination":-7.059708, "Periapsis":335.807587, "OrbitalPeriod":43402832.000000, "RotationPeriod":104971.531250 }
{ "timestamp":"2017-01-02T02:44:30Z", "event":"USSDrop", "USSType":"$USS_Type_Salvage;", "USSType_Localised":"Degraded emissions detected", "USSThreat":0 }
fredjk-gh commented 1 year ago

Finally got to this. I'll get new versions posted up soon.