fredjk-gh / ObservatoryPlugins

A suite of plugins for Elite ObservatoryCore (https://github.com/Xjph/ObservatoryCore).
MIT License
6 stars 1 forks source link

Carrier Duplication #3

Closed Xjph closed 1 month ago

Xjph commented 1 month ago

Back in June of 2020 Frontier rolled out a patch that changed carrier IDs as a side effect. That means that carriers which span this change are reported as two carriers by Fleet Commander after a read all, one of which is very stale.

Pretty minor, but if this could be handled gracefully it would be nice. :)

fredjk-gh commented 1 month ago

Ok, the fix is pretty basic as well: When adding a new carrier for a commander, if I find one for the commander already, I'll remove it and carry on. Basically, I assume there exists at most one carrier per commander.

It would be unreliable to assume the carrier name is the same, but for now, 1 carrier per commander is reasonable. As far as I know that decommissioning and re-buying a carrier doesn't change the callsign.

Fix will be committed soon and will in the next beta release of the plugin.