search

fredlcore / BSB-LAN

LAN/WiFi interface for Boiler-System-Bus (BSB) and Local Process Bus (LPB) and Punkt-zu-Punkt Schnittstelle (PPS) with a Siemens® controller used by Elco®, Brötje® and similar heating systems
231 stars 84 forks source link

[FEATURE REQUEST] MQTT port #452

Closed tobyDoh closed 2 years ago

tobyDoh commented 2 years ago

Is your feature request related to a problem? Please describe. MQTT Port is currently hard-coded in Programm

Describe the solution you'd like Have the MQTT Port avaiable as Option in header as variable or better as option in webinterface

Describe alternatives you've considered changing the coding prior to compiling process

Describe your own contribution i will test the changes

fredlcore commented 2 years ago

Since the webinterface is already quite "full", I'd prefer only to add necessary configuration options. What is the benefit of adding a configuration option to configure the MQTT port? Especially in relation to all other network ports we are using? If we start making one of them configurable, we would have to do the same with all the others as well. If you are looking for security through obfuscation, it won't bring much in a local network where local users connected to the network can easily monitor the unencrypted communication on all ports.

zonfacter commented 2 years ago

Letztendlich ist es Bequemlichkeit.

Ich habe auch den Standard Port gelassen, aber mein Sonoff Adapter im iobroker kommt mit dem übertragungstext nicht klar, ein weiteren MQTT Broker/Client Service hab ich auf 1884 am laufen...Jetzt müsste ich es neu flashen, hab ich aber keine Lust... Jetzt hab ich Glück das es einen Adapter gibt für iobroker somit bleibt es wie es ist...

fredlcore commented 2 years ago

Ok, thanks.