search

fredlcore / BSB-LAN

LAN/WiFi interface for Boiler-System-Bus (BSB) and Local Process Bus (LPB) and Punkt-zu-Punkt Schnittstelle (PPS) with a Siemens® controller used by Elco®, Brötje® and similar heating systems
225 stars 84 forks source link

feat: added enum-texts for 832, 5890, 5930 and additional entry 616 for FUJITSU 170 #466

Closed Duesentrieb5413 closed 1 year ago

Duesentrieb5413 commented 2 years ago

Added enum-texts for 832, 5890, 5930 Added additional entry 616 for FUJITSU 170

1coderookie commented 2 years ago

Thanks! @fredlcore : I wonder if/why we don't have them yet, because they're part of the RVSx1 controller already (and e.g. Trinkwasserfühler B3 should already be existent anyway I would have assumed)..?

Anyway @Duesentrieb5413 - could you please change the abbreviation "Quellenaust'fühler" to the full expression "Quellenaustrittfühler"?

And just in case you're willing to edit LANG_EN also, here are the belonging translations:

"Kondensatorpumpe Q9" = "Condenser pump Q9"
"Trinkwasserfühler B3" = "DHW sensor B3"
"WP Vorlauffühler B21" = "HP flow sensor B21"
"WP Rücklauffühler B71" = "HP return sensor B71"
"Heissgasfühler B81" = "Hot-gas sensor B81"
"Aussentemperaturfühler B9" = "Outside temperature B9"
"Quelleneintrittfühler B91" = "Source inlet temperature B91"
"Quellenaustrittfühler B92/B84" = "Source outlet temperature B92/B84"
"Raumfühler B5" = "Room sensor B5"
fredlcore commented 2 years ago

@1coderookie Yes, we do have these parameters already, but apparently not the specific option values. And yes, some of the translations already exist. @Duesentrieb5413 We only add text descriptions (whether it's parameter names or options) in LANG_XX.h if the same phrase has never appeared before. In this case, for example, "Trinkwasserfühler B3" already exists in this line: #define ENUM4133_01_TEXT "Trinkwasserfühler B3" So in order to save flash space and work for translators, this will be cross-referenced in BSB_LAN_defs.h like this #define ENUM5930_13_TEXT ENUM4133_01_TEXT and so on.

I guess we should mention somewhere that if people want to contribute translations (which we of course really welcome), they should get in touch with us first to understand the mechanism that the language files are designed upon in order to save everyone unnecessary work...

Duesentrieb5413 commented 2 years ago

Removed duplicate texts from German language file and added translations to English language file. Furthermore pushed automatically adapted web files to be included in the pull request.

fredlcore commented 1 year ago

Mit der Version 3.0 und den reglerspezifischen BSB_LAN_custom_defs.h wird sich die Übersetzung der Parameter erübrigen, trotzdem vielen Dank für Deinen Einsatz!

Duesentrieb5413 commented 1 year ago

@fredlcore : why is this request closed without adding the provided parameters/texts to the code? Several new texts were added, which I currently cannot find in the appropriate BSB_LAN_custom_defs.h, e.g.

fredlcore commented 1 year ago

See here: https://github.com/fredlcore/BSB-LAN/discussions/482 Translations will be taken from the heater's definitions. The current BSB_LAN_custom_defs.h is still reflecting the old "complete" list, so they're not included there. But since this is legacy, it won't make sense to include new translations.