[BUG] Cannot compile sketch if certain extensions are not defined

mirkolenz commented 2 years ago

BSB-LAN Version As displayed in the web-configuration or copy from bsb-version.h file.

#define MAJOR "2"
#define MINOR "1"
#define PATCH "8"
#define COMPILETIME "20220731102301"

Architecture The architecture BSB-LAN is running on (Arduino Mega, Arduino Due, ESP32 NodeMCU, ESP32 Olimex EVB etc.)

ESP23 Olimex

Bus system Which bus BSB-LAN is running on (BSB, LPB, PPS)?

BSB

Describe the bug A clear and concise description of what the bug is.

If commenting out certain #define commands in BSB_LAN_config.h, the sketch does not compile anymore. This bug did not occur for me when using version 2.0.

To Reproduce Steps to reproduce the behavior:

Comment out #define WEBCONFIG and the complete block of #define MAX_CUL.
Try to verify/upload the sketch.

Logs If possible, attach or copy/paste a log of the Arduino IDE's serial monitor when performing the above actions. If the error is reproducible, do so after pressing the reset button on the board.

There will be errors complaining that multiple variables are not set. If commenting out WEBCONFIG, CF_LOGAVERAGES_TXT (among others) is not found, in case of MAX_CUL, max_device_list is not found.

Expected behavior A clear and concise description of what you expected to happen.

The sketch should compile without issues as was the case in version 2.0

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

Arduino IDE Version: 2.0.0-rc9.2

dukess commented 2 years ago

Try to compile sketch with default config file.

mirkolenz commented 2 years ago

Thank you for the fast reply! In the default config file, MAX_CUL and WEBCONFIG are enabled, thus it compiles just fine. The same is true for my own configuration: If enabling those two extension, everything is alright. But if removing them, the compilation fails. In version 2.0, it was possible to disable these without any issues.

dukess commented 2 years ago

strange things, i will check it little bit later.

dukess commented 2 years ago

Can't reproduce error :( Arduino IDE 1.8.19

mirkolenz commented 2 years ago

Mmh, maybe this is related to the version of the Arduino IDE and the fact that I ak compiling it for an ESP32 board? I will remove any sensitive data from my configuration tomorrow and upload it here so that it may be possible for you to reproduce the issue. Thank you very much for the quick reply!

mirkolenz commented 2 years ago

As promised, here is my configuration file. The remaining custom header files are all empty in my setup, so only BSB_LAN_config.h differs from the default one found in the GitHub repo. Maybe this issue is only triggered by a very specific combination of parameters that I disabled for my setup.

/************************************************************************************/
/************************************************************************************/
/* Settings -   BEGIN                                                               */
/************************************************************************************/
/************************************************************************************/

// Upon first installation, rename this file from BSB_lan_config.h.default to BSB_lan_config.h and adjust settings accordingly
// Users who still use Arduino Mega2560 boards instead of Arduin Due: Please have a look at the very end of this configuration
// where certain modules are disabled by default due to limited flash memory.

/* Select language; so far German is the most complete, with English following.
 * Available languages are: Czech (CS), German (DE), Danish (DA), English (EN), Spanish (ES), Finnish (FI),
 * French (FR), Greek (EL), Hungarian (HU), Italian (IT), Dutch (NL), Polish (PL), Russian (RU), Swedish (SV),
 * Slovenian (SI) and Turkish (TR).
 * Incomplete languages will automatically be filled up with English translations first, and if no English translation
 * is available, fallback will take place to German.
*/
#define LANG EN

/*
Allow to initialize program configuration by reading settings from EEPROM
byte UseEEPROM = 0; // Configuration is read from this config file.
                    // Configuration can be stored in EEPROM but will not used while UseEEPROM is zero.
                    // Set zero for fallback startup in case EEPROM configuration is broken.
byte UseEEPROM = 1; // Configuration will be read from EEPROM. This is the default.
*/
byte UseEEPROM = 0;

/*
 *  Enter a MAC address, found either on the EthernetShield or use the one below.
 *  Change this if you have more than one BSB-LAN adapter in your LAN, so that there aren't any address conflicts.
 *  MAC address here only affects the LAN shield, it doesn't apply to the WiFi-ESP-solution.
*/
byte mac[6] = { 0x00, 0x80, 0x41, 0x19, 0x69, 0x90 };

/*
 * Initialize the Ethernet server library
 * with the IP address and port you want to use
 * (port 80 is default for HTTP):
*/

uint16_t HTTPPort = 80;
bool useDHCP = true;                 // Set to false if you want to use a fixed IP.
byte ip_addr[4] = {192,168,178,88};     // Please note the commas instead of dots!!!  Set useDHCP to true if you want DHCP.
byte gateway_addr[4] = {192,168,178,1}; // Gateway address. This is usually your router's IP address. Please note the commas instead of dots!!! Ignored if first value is 0.
byte dns_addr[4] = {192,168,178,1};     // DNS server. Please note the commas instead of dots!!! Ignored if first value is 0.
byte subnet_addr[4] = {255,255,255,0};  // Subnet address. Please use commas instead of dots!!! Ignored if first value is 0.

//#define WIFI                          // Activate this definement if you want to use WiFi. Note: MAC address can't be set individually.
char wifi_ssid[32] = "YourWiFiNetwork"; // enter your WiFi network name (SSID) here
char wifi_pass[64] = "YourWiFiPassword";// enter your WiFi password here
#define WIFI_SPI_SS_PIN 12              // defines SPI-SS pin for Arduino-ESP8266 connection

#define MDNS_SUPPORT                   // Advertises the hostname in the local network. Disable this if you don't want your device to be found under this name in your network.
char mDNS_hostname[32] = "BSB-LAN";

#define DEBUG         // Compile with verbose DEBUG module if defined
byte debug_mode = 1;  // Debug mode: 0 - disabled, 1 - send debug messages to serial interface, 2 - send debug messages to telnet client
byte verbose = 1;     // If set to 1, all messages on the bus are printed to debug interface
byte monitor = 0;     // Bus monitor mode. This is only necessary for in-depth debug sessions.
bool show_unknown = true; // true - show all parameters, false - hide unknown parameters from web display (parameters will still be queried and therefore take time!)

/* SECURITY OPTIONS
 * There are several options to control and protect access to your heating system. However, keep
 * in mind, that even activating all three options are no guarantee that a versatile intruder with
 * access to your (W)LAN won't be able to gain access. In any case, no encryption of data streams
 * is provided from the Arduino itself. Use VPN or a SSL proxy if that is a must for you and connect
 * the Arduino wired to the VPN server or SSL proxy. On the other hand, someone with this amount
 * of criminal activity will probably have it easier just to access your heating system face-to-face ;)
*/

/*
 * if PASSKEY length is non-zero, the URL has to contain the defined passkey as first element
 * e.g.
 * char PASSKEY[64] = "1234";
 * http://192.168.178.88/1234/                - to view the main website (don't forget the trailing slash!)
 * http://192.168.178.88/1234/K               - to list all categories
 * http://192.168.178.88/1234/8700/8740/8741  - to list parameters 8700, 8740 and 8741 in one request
*/
char PASSKEY[64] = "";

/* activate IP-address-based access.
You can set any ip address as trusted.
Not used if first byte is 0
*/
byte trusted_ip_addr[4] = {0,0,0,0};
byte trusted_ip_addr2[4] = {0,0,0,0};

/* Activate HTTP-Auth authentication to provide username/password based access. No encryption!
 * Credentials have to be entered in the form
 * User:Password
 */
//char USER_PASS[64] = "User:Password";
char USER_PASS[64] = "";      // HTTP-Auth will be disabled if USER_PASS string length is zero

// Compile module with one wire bus support.
#define ONE_WIRE_BUS
byte One_Wire_Pin = 0;         // Define the pin for one wire temperature sensors. 0 - disable oneWire bus

// Compile module with DHT temperature/humidity sensors support
#define DHT_BUS
// Define the pins for DHT temperature/humidity sensors (Up to 10)
uint8_t DHT_Pins[10] = {0};

// Compile module with BME280 temperature/humidity/pressure sensors support on I2C bus.
// Up to two sensors with 0x76 and 0x77 addresses.
#define BME280
byte BME_Sensors = 0; //Define number of BME280 sensors

// Compile module for calculation 24h averages for selected programs
#define AVERAGES
// Create 24h averages from these parameters and save data into averages.txt on SD-card.
int avg_parameters[40] = {
  8700,                         // Außentemperatur
  8326                          // Brenner-Modulation
};

/* Compile module for logging on SD-card.
Requires a FAT32-formatted Micro-SD card inserted into the Ethernet-Shield's card slot
Does: log bus telegrams to file
      log selected values to file
      store to SD and load selected 24h averages
      push selected values to an MQTT broker*/
#define LOGGER

// Use SD card adapter on ESP32-based boards instead of SPIFFS flash-based storage
#define ESP32_USE_SD

// Log "raw" bus telegrams. Data saved in journal.txt on SD-card.
// Telegrams logged upon boot:
// int logTelegram = LOGTELEGRAM_OFF; // nothing to log,
// int logTelegram = LOGTELEGRAM_ON;  // log all telegrams,
// int logTelegram = LOGTELEGRAM_ON + LOGTELEGRAM_UNKNOWN_ONLY;           // log unknown telegrams,
// int logTelegram = LOGTELEGRAM_ON + LOGTELEGRAM_BROADCAST_ONLY;         // log broadcast telegrams,
// int logTelegram = LOGTELEGRAM_ON + LOGTELEGRAM_UNKNOWNBROADCAST_ONLY;  // log unknown broadcast telegrams only;
int logTelegram = LOGTELEGRAM_OFF;

// Logging data from parameters
// Interval and list of parameters can be redefined through /L command during runtime
// Data will be written to "datalog.txt"
unsigned long log_interval = 60;  // Logging interval (to SD card and MQTT broker) in seconds
int log_parameters[40] = {
  8310, // Kesseltemperatur-Istwert (C)
  8314, // Rücklauftemperatur-Istwert (C)
  8316, // Abgastemperatur-Istwert (C)
  // 8323, // Gebläsedrehzahl (U/min)
  8325, // Aktuelle Gebläseansteuerung (%)
  8326, // Brennermodulation (%)
  8327, // Wasserdruck (-)
  // 8329, // Ionisationsstrom Istwert (mikroA)
  8700, // Aussentemperatur (C)
  8735, // Heizkreispumpe Drehzahl HK1 (%)
  8743, // Vorlauftemperatur Istwert Heizkreis 1 (C)
  // 8750, // Not in manual: Pump speed (%)
  8825, // Drehzahl Trinkwasserpumpe (%)
  8830, // Trinkwassertemperatur-Istwert
  // 8860, // Trinkwasserdurchfluss (l/min)
//  20000,                  // Spezialparameter: Brenner-Laufzeit Stufe 1
//  20001,                  // Spezialparameter: Brenner-Takte Stufe 1
//  20002,                  // Spezialparameter: Brenner-Laufzeit Stufe 2
//  20003,                  // Spezialparameter: Brenner-Takte Stufe 2
//  20004,                  // Spezialparameter: TWW-Laufzeit
//  20005,                  // Spezialparameter: TWW-Takte
//  20050,                  // Spezialparameter 20050-20099: 24h-Durchschnittswerte
//  20100,                  // Spezialparameter 20100-20299: DHT22-Sensoren 1-50
//  20300                   // Spezialparameter 20300-20499: DS18B20-Sensoren 1-100
//  20500                   // Spezialparameter 20500-20699: MAX!-Sensoren 1-50
};

// Compile MQTT extension: activate sending log_parameters to MQTT broker every log_interval seconds
#define MQTT
byte mqtt_mode = 1; // MQTT: 1 - send messages in plain text format, 2 - send messages in JSON format, 3 - send messages in rich JSON format. Use this if you want a json package of your logging information printed to the mqtt topic
// rich JSON payload will be of the structure: {"MQTTDeviceID": {"id": "parmeter number from log values", "name": "parameter name from logvalues", "value": "query result", "desc": "enum value description", "unit": "unit of measurement", "error", error code}}
byte mqtt_broker_ip_addr[4] = {1,1,1,1}; // MQTT broker ip address. Please use commas instead of dots!!!
char MQTTUsername[32] = "user";                 // Set username for MQTT broker here or set empty string if no username/password is used.
char MQTTPassword[32] = "pass";                 // Set password for MQTT broker here or set empty string if no password is used.
char MQTTTopicPrefix[32] = "bsblan";            // Optional: Choose the "topic" for MQTT messages here. In case of empty string, default topic name will be used

// Optional: Define a device name to use as header in json payload. In case of empty string, "BSB-LAN" will be used.
// This value is also used as a client ID towards the MQTT broker, change it if you have more than one BSB-LAN on your broker.
char MQTTDeviceID[32] = "bsblan";

// Logging mode: 0 - disabled, 1 - write values to SD card, 2 - write 24h averages to SD card, 4 - send values to MQTT, 8 -  send values to UDP. Can be conjunction of these values.
byte LoggingMode = 4; //CF_LOGMODE_SD_CARD | CF_LOGMODE_SD_CARD_24AVG | CF_LOGMODE_MQTT | CF_LOGMODE_UDP

// Compile IPWE extension

#define IPWE
bool enable_ipwe = true;  // true - activate IPWE extension (http://xxx.xxx.xxx.xxx/ipwe.cgi)
// Parameters to be displayed in IPWE extension
int ipwe_parameters[40] = {
  8310, // Kesseltemperatur-Istwert (C)
  8314, // Rücklauftemperatur-Istwert (C)
  8316, // Abgastemperatur-Istwert (C)
  // 8323, // Gebläsedrehzahl (U/min)
  8325, // Aktuelle Gebläseansteuerung (%)
  8326, // Brennermodulation (%)
  8327, // Wasserdruck (-)
  // 8329, // Ionisationsstrom Istwert (mikroA)
  8700, // Aussentemperatur (C)
  8735, // Heizkreispumpe Drehzahl HK1 (%)
  8743, // Vorlauftemperatur Istwert Heizkreis 1 (C)
  // 8750, // Not in manual: Pump speed (%)
  8825, // Drehzahl Trinkwasserpumpe (%)
  8830, // Trinkwassertemperatur-Istwert
  // 8860, // Trinkwasserdurchfluss (l/min)
};

// If you prefer to use the log file plotting (/DG) used in BSB-LAN 2.1.3, disable the following #define.
// Otherwise a newer implementation will be used that does require (automated) loading of an additional
// Javascript library off the internet (currently 204 KB), but offers the following improvements:
// - better legibility for value numbers with plot lines close to each other (mouseover on plot)
// - user can interactively highlight plot lines for improved overview (mouseover on legend entries)
// - user can interactively disable plot lines for improved overview and vertical scaling (click on legend entries)
// - added zoom (mousewheel/pinch on plot) and pan capability (drag zoomed-in plot)
// - saves over 4 KB in compiled BSB-LAN sketch
#define USE_ADVANCED_PLOT_LOG_FILE

// Compile CUNO/CUNX/modified MAX!Cube extension.
#define MAX_CUL
bool enable_max_cul = false;                // enable or disable connection to CUNO/CUNX/modified MAX!Cube;
byte max_cul_ip_addr[4] = {192,168,178,5};     // IP of CUNO/CUNX/modified MAX!Cube. Please use commas instead of dots!!!
char max_device_list[20][11] = {               // list of MAX! wall/heating thermostats that should be polled
  "KEQ0502326",                                // use MAX! serial numbers here which have to have exactly 10 characters
  "KEQ0505080"
};

// defines the number of retries for the query command
#define QUERY_RETRIES  3

// Setting bus pins and bus type

byte bus_pins[2] = {0,0}; //First value - RX pin, second value - TX pin. 0,0 - auto select (19,18 for Due, 16,17 for NodeMCU, 36,17 for Olimex EVB and 68,69 for Mega).
uint8_t bus_type = 0;  // set bus system at boot: 0 = BSB, 1 = LPB, 2 = PPS
// BSB:
// - 'own_address' sets own address, defaults to 0x42 (LAN in serial monitor)
// - 'dest_address' sets destination address, defaults to 0 for heating system.
// LPB:
// - 'own_address and 'dest_address' set own and destination address (high nibble = segment, low nibble = device minus 1)
// - defaults to 0x42 for own address and 0x00 for destination address, i.e. segment 4, device 3 for Arduino/BSB-LAN and segment 0, device 1 for heating system
byte own_address = 0x42;
byte dest_address = 0x00;
// PPS:
// - set 'pps_write' to "1" to enable writing to heater - only use this if there is no other room controller (such as QAA50/QAA70) active.
bool pps_write = 0;
byte QAA_TYPE = 0x53;  // 0x53 = QAA70, 0x52 = QAA50, 0x5A = QAA10, 0x37 = QAA95, 0x66 = BMU, 0xEA = MCBA/REA70/DC225

/* Set the device family and device variant of your heating system. Only change this if you _really_ know what you are doing!
 * Set fixed_device_family and fixed_device_variant to your device family and variant (parameters 6225 and 6226) here
 * if heating system is not running when Arduino is powered on.
*/
uint16_t fixed_device_family = 0;
uint16_t fixed_device_variant = 0;

// defines default flag for parameters
// use "#define DEFAULT_FLAG FL_SW_CTL_RONLY" to control read/write functionality via configuration in web interface.
// use "#define DEFAULT_FLAG 0" to make (almost) all parameters writeable
// use #define DEFAULT_FLAG FL_RONLY to run the program always in read-only mode.
#define DEFAULT_FLAG FL_SW_CTL_RONLY

// include commands from BSB_lan_custom.h to be executed at the end of each main loop
//#define CUSTOM_COMMANDS

/*
 * Check for new versions when accessing BSB-LAN's main page.
 * Doing so will poll the most recent version number from the BSB-LAN server.
 * In this process, it is unavoidable that your IP address will be transferred to the server, obviously.
 * We nevertheless mention this here because this constitutes as 'personal data' and this feature is therefore disabled by default.
 * Activating this feature means you are consenting to transmitting your IP address to the BSB-LAN server where it will be stored
 * for up to two weeks in the server's log files to allow for technical as well as abuse analaysis.
 * No other data (such as anything related to your heating system) is transmitted in this process, as you can see in the source code.
*/
#define VERSION_CHECK
bool enable_version_check = false;

#define ENABLE_ESP32_OTA
boolean enable_ota_update = true;

// "External" web server. Read files from SD-card. Only static content: html, js, css, jpg, etc.
//#define WEBSERVER

// Configuration will be stored in EEPROM
// #define CONFIG_IN_EEPROM

// Compile web-based configuration and EEPROM config store module extension.
#define WEBCONFIG

// Compile JSON-based configuration and EEPROM config store module extension.
// #define JSONCONFIG

#define RGT_EMULATOR
int rgte_sensorid[3][5] = {{0, 0, 0, 0, 0}, {0, 0, 0, 0, 0}, {0, 0, 0, 0, 0}}; //Temperature sensor program IDs for RGT1/PPS - RGT3. If zero then RGT will not be emulated. If more than one program set per RGT then average will be calculated and used.

//Enable presence buttons and TWW/DHW push on selected pins.
// Pins on Mega can be (Digital) 2, 3, 18, 19, 20, 21
// On Due any Digital pins can be selected excluding 12, 16-21, 31, 33, 53.
// Make sure you aren't using pins which are already in use for sensors (default: 2, 3, 7) or change them accordingly.
#define BUTTONS
uint8_t button_on_pin[4] = {0, 0, 0, 0}; //Order: TWW push, presence ROOM1, presence ROOM2, presence ROOM3

// Variables for future use:
// Compile room unit replacement extension
#define ROOM_UNIT
byte UdpIP[4] = {0,0,0,0}; // (destination IP address for sending UDP packets to, the room unit replacement of FHEM user @fabulous uses that)
uint16_t UdpDelay = 15;    // (interval in seconds to send UDP packets)

// Compile off-site logger extension
#define OFF_SITE_LOGGER
byte destinationServer[128] = "";   // URL string to periodically send values to an off-site logger
uint16_t destinationPort = 80;      // port number for abovementioned server
uint32_t destinationDelay = 84600;  // interval in seconds to send values

/*
 * For Arduino Mega users:
 *
 * If you use CONFIG_IN_EEPROM and WEBCONFIG modules then
 * you can enable I_DO_NOT_WANT_URL_CONFIG for saving flash memory (~1.2Kb).
 * This will disable configuration through URL commands (/A, /L, /P)
 * #define I_DO_NOT_WANT_URL_CONFIG
 *
 * Enable I_WILL_USE_EXTERNAL_INTERFACE for saving flash memory (~6,8Kb). /DG command will be disabled
 * #define I_WILL_USE_EXTERNAL_INTERFACE
 *
 * Enabling I_DO_NOT_NEED_NATIVE_WEB_INTERFACE will eliminate native web interface and save up to 13 Kb of flash memory.
 * /N[E] and /Q command still work
 * You can use this if you are using third-party software for BSB-LAN management. Do not forget to enable other required modules (JSONCONFIG, MQTT, WEBSERVER).
 * #define I_DO_NOT_NEED_NATIVE_WEB_INTERFACE
 */

// By default, the following modules are disabled for the Arduino Mega2560 due to lack of memory.
// This overwrites any definements above.
// You are of course free to make changes here so that they fit your needs and the Mega's memory constraints.
#if defined(__AVR__)
//#undef CONFIG_IN_EEPROM
//#undef WEBCONFIG
#undef JSONCONFIG
//#undef WEBSERVER
#undef AVERAGES
#undef DEBUG
#undef IPWE
#undef MQTT
#undef MDNS_HOSTNAME
#undef OFF_SITE_LOGGER
#undef ROOM_UNIT
#undef VERSION_CHECK
#undef MAX_CUL
#undef BME280
#endif
/************************************************************************************/
/************************************************************************************/
/* Settings -   END                                                                 */
/************************************************************************************/
/************************************************************************************/

dukess commented 2 years ago

Can you put here compilation log?

Mirko Lenz @.***> 31 августа 2022 г. 12:23:31 написал:

As promised, here is my configuration file. The remaining custom header files are all empty in my setup, so only BSB_LAN_config.h differs from the default one found in the GitHub repo. Maybe this issue is only triggered by a very specific combination of parameters that I disabled for my setup. /****/ /****/ / Settings - BEGIN / /****/ /****/ // Upon first installation, rename this file from BSB_lan_config.h.default to BSB_lan_config.h and adjust settings accordingly // Users who still use Arduino Mega2560 boards instead of Arduin Due: Please have a look at the very end of this configuration // where certain modules are disabled by default due to limited flash memory. /* Select language; so far German is the most complete, with English following.

Available languages are: Czech (CS), German (DE), Danish (DA), English (EN), Spanish (ES), Finnish (FI),

French (FR), Greek (EL), Hungarian (HU), Italian (IT), Dutch (NL), Polish (PL), Russian (RU), Swedish (SV),

Slovenian (SI) and Turkish (TR).

Incomplete languages will automatically be filled up with English translations first, and if no English translation

is available, fallback will take place to German. */
define LANG EN /*

Allow to initialize program configuration by reading settings from EEPROM byte UseEEPROM = 0; // Configuration is read from this config file. // Configuration can be stored in EEPROM but will not used while UseEEPROM is zero. // Set zero for fallback startup in case EEPROM configuration is broken. byte UseEEPROM = 1; // Configuration will be read from EEPROM. This is the default. / byte UseEEPROM = 0; /

Enter a MAC address, found either on the EthernetShield or use the one below.

Change this if you have more than one BSB-LAN adapter in your LAN, so that there aren't any address conflicts.

MAC address here only affects the LAN shield, it doesn't apply to the WiFi-ESP-solution. / byte mac[6] = { 0x00, 0x80, 0x41, 0x19, 0x69, 0x90 }; /

Initialize the Ethernet server library

with the IP address and port you want to use

(port 80 is default for HTTP): */ uint16_t HTTPPort = 80; bool useDHCP = true; // Set to false if you want to use a fixed IP. byte ip_addr[4] = {192,168,178,88}; // Please note the commas instead of dots!!! Set useDHCP to true if you want DHCP. byte gateway_addr[4] = {192,168,178,1}; // Gateway address. This is usually your router's IP address. Please note the commas instead of dots!!! Ignored if first value is 0. byte dns_addr[4] = {192,168,178,1}; // DNS server. Please note the commas instead of dots!!! Ignored if first value is 0. byte subnet_addr[4] = {255,255,255,0}; // Subnet address. Please use commas instead of dots!!! Ignored if first value is 0. //#define WIFI // Activate this definement if you want to use WiFi. Note: MAC address can't be set individually. char wifi_ssid[32] = "YourWiFiNetwork"; // enter your WiFi network name (SSID) here char wifi_pass[64] = "YourWiFiPassword";// enter your WiFi password here
define WIFI_SPI_SS_PIN 12 // defines SPI-SS pin for Arduino-ESP8266

connection #define MDNS_SUPPORT // Advertises the hostname in the local network. Disable this if you don't want your device to be found under this name in your network. char mDNS_hostname[32] = "BSB-LAN"; #define DEBUG // Compile with verbose DEBUG module if defined byte debug_mode = 1; // Debug mode: 0 - disabled, 1 - send debug messages to serial interface, 2 - send debug messages to telnet client byte verbose = 1; // If set to 1, all messages on the bus are printed to debug interface byte monitor = 0; // Bus monitor mode. This is only necessary for in-depth debug sessions. bool show_unknown = true; // true - show all parameters, false - hide unknown parameters from web display (parameters will still be queried and therefore take time!) /* SECURITY OPTIONS

There are several options to control and protect access to your heating system. However, keep

in mind, that even activating all three options are no guarantee that a versatile intruder with

access to your (W)LAN won't be able to gain access. In any case, no encryption of data streams

is provided from the Arduino itself. Use VPN or a SSL proxy if that is a must for you and connect

the Arduino wired to the VPN server or SSL proxy. On the other hand, someone with this amount

of criminal activity will probably have it easier just to access your heating system face-to-face ;) / /

if PASSKEY length is non-zero, the URL has to contain the defined passkey as first element

e.g.

char PASSKEY[64] = "1234";

http://192.168.178.88/1234/ - to view the main website (don't forget the trailing slash!)

http://192.168.178.88/1234/K - to list all categories

http://192.168.178.88/1234/8700/8740/8741 - to list parameters 8700, 8740 and 8741 in one request / char PASSKEY[64] = ""; / activate IP-address-based access. You can set any ip address as trusted. Not used if first byte is 0 / byte trusted_ip_addr[4] = {0,0,0,0}; byte trusted_ip_addr2[4] = {0,0,0,0}; / Activate HTTP-Auth authentication to provide username/password based access. No encryption!

Credentials have to be entered in the form

User:Password */ //char USER_PASS[64] = "User:Password"; char USER_PASS[64] = ""; // HTTP-Auth will be disabled if USER_PASS string length is zero // Compile module with one wire bus support.
define ONE_WIRE_BUS

byte One_Wire_Pin = 0; // Define the pin for one wire temperature sensors. 0 - disable oneWire bus // Compile module with DHT temperature/humidity sensors support

define DHT_BUS

// Define the pins for DHT temperature/humidity sensors (Up to 10) uint8_t DHT_Pins[10] = {0}; // Compile module with BME280 temperature/humidity/pressure sensors support on I2C bus. // Up to two sensors with 0x76 and 0x77 addresses.

define BME280

byte BME_Sensors = 0; //Define number of BME280 sensors // Compile module for calculation 24h averages for selected programs

define AVERAGES

// Create 24h averages from these parameters and save data into averages.txt on SD-card. int avg_parameters[40] = { 8700, // Außentemperatur 8326 // Brenner-Modulation }; / Compile module for logging on SD-card. Requires a FAT32-formatted Micro-SD card inserted into the Ethernet-Shield's card slot Does: log bus telegrams to file log selected values to file store to SD and load selected 24h averages push selected values to an MQTT broker/

define LOGGER // Use SD card adapter on ESP32-based boards instead of

SPIFFS flash-based storage

define ESP32_USE_SD // Log "raw" bus telegrams. Data saved in journal.txt

on SD-card. // Telegrams logged upon boot: // int logTelegram = LOGTELEGRAM_OFF; // nothing to log, // int logTelegram = LOGTELEGRAM_ON; // log all telegrams, // int logTelegram = LOGTELEGRAM_ON + LOGTELEGRAM_UNKNOWN_ONLY; // log unknown telegrams, // int logTelegram = LOGTELEGRAM_ON + LOGTELEGRAM_BROADCAST_ONLY; // log broadcast telegrams, // int logTelegram = LOGTELEGRAM_ON + LOGTELEGRAM_UNKNOWNBROADCAST_ONLY; // log unknown broadcast telegrams only; int logTelegram = LOGTELEGRAM_OFF; // Logging data from parameters // Interval and list of parameters can be redefined through /L command during runtime // Data will be written to "datalog.txt" unsigned long log_interval = 60; // Logging interval (to SD card and MQTT broker) in seconds int log_parameters[40] = { 8310, // Kesseltemperatur-Istwert (C) 8314, // Rücklauftemperatur-Istwert (C) 8316, // Abgastemperatur-Istwert (C) // 8323, // Gebläsedrehzahl (U/min) 8325, // Aktuelle Gebläseansteuerung (%) 8326, // Brennermodulation (%) 8327, // Wasserdruck (-) // 8329, // Ionisationsstrom Istwert (mikroA) 8700, // Aussentemperatur (C) 8735, // Heizkreispumpe Drehzahl HK1 (%) 8743, // Vorlauftemperatur Istwert Heizkreis 1 (C) // 8750, // Not in manual: Pump speed (%) 8825, // Drehzahl Trinkwasserpumpe (%) 8830, // Trinkwassertemperatur-Istwert // 8860, // Trinkwasserdurchfluss (l/min) // 20000, // Spezialparameter: Brenner-Laufzeit Stufe 1 // 20001, // Spezialparameter: Brenner-Takte Stufe 1 // 20002, // Spezialparameter: Brenner-Laufzeit Stufe 2 // 20003, // Spezialparameter: Brenner-Takte Stufe 2 // 20004, // Spezialparameter: TWW-Laufzeit // 20005, // Spezialparameter: TWW-Takte // 20050, // Spezialparameter 20050-20099: 24h-Durchschnittswerte // 20100, // Spezialparameter 20100-20299: DHT22-Sensoren 1-50 // 20300 // Spezialparameter 20300-20499: DS18B20-Sensoren 1-100 // 20500 // Spezialparameter 20500-20699: MAX!-Sensoren 1-50 }; // Compile MQTT extension: activate sending log_parameters to MQTT broker every log_interval seconds

define MQTT

byte mqtt_mode = 1; // MQTT: 1 - send messages in plain text format, 2 - send messages in JSON format, 3 - send messages in rich JSON format. Use this if you want a json package of your logging information printed to the mqtt topic // rich JSON payload will be of the structure: {"MQTTDeviceID": {"id": "parmeter number from log values", "name": "parameter name from logvalues", "value": "query result", "desc": "enum value description", "unit": "unit of measurement", "error", error code}} byte mqtt_broker_ip_addr[4] = {1,1,1,1}; // MQTT broker ip address. Please use commas instead of dots!!! char MQTTUsername[32] = "user"; // Set username for MQTT broker here or set empty string if no username/password is used. char MQTTPassword[32] = "pass"; // Set password for MQTT broker here or set empty string if no password is used. char MQTTTopicPrefix[32] = "bsblan"; // Optional: Choose the "topic" for MQTT messages here. In case of empty string, default topic name will be used // Optional: Define a device name to use as header in json payload. In case of empty string, "BSB-LAN" will be used. // This value is also used as a client ID towards the MQTT broker, change it if you have more than one BSB-LAN on your broker. char MQTTDeviceID[32] = "bsblan"; // Logging mode: 0 - disabled, 1 - write values to SD card, 2 - write 24h averages to SD card, 4 - send values to MQTT, 8 - send values to UDP. Can be conjunction of these values. byte LoggingMode = 4; //CF_LOGMODE_SD_CARD | CF_LOGMODE_SD_CARD_24AVG | CF_LOGMODE_MQTT | CF_LOGMODE_UDP // Compile IPWE extension #define IPWE bool enable_ipwe = true; // true - activate IPWE extension (http://xxx.xxx.xxx.xxx/ipwe.cgi) // Parameters to be displayed in IPWE extension int ipwe_parameters[40] = { 8310, // Kesseltemperatur-Istwert (C) 8314, // Rücklauftemperatur-Istwert (C) 8316, // Abgastemperatur-Istwert (C) // 8323, // Gebläsedrehzahl (U/min) 8325, // Aktuelle Gebläseansteuerung (%) 8326, // Brennermodulation (%) 8327, // Wasserdruck (-) // 8329, // Ionisationsstrom Istwert (mikroA) 8700, // Aussentemperatur (C) 8735, // Heizkreispumpe Drehzahl HK1 (%) 8743, // Vorlauftemperatur Istwert Heizkreis 1 (C) // 8750, // Not in manual: Pump speed (%) 8825, // Drehzahl Trinkwasserpumpe (%) 8830, // Trinkwassertemperatur-Istwert // 8860, // Trinkwasserdurchfluss (l/min) }; // If you prefer to use the log file plotting (/DG) used in BSB-LAN 2.1.3, disable the following #define. // Otherwise a newer implementation will be used that does require (automated) loading of an additional // Javascript library off the internet (currently 204 KB), but offers the following improvements: // - better legibility for value numbers with plot lines close to each other (mouseover on plot) // - user can interactively highlight plot lines for improved overview (mouseover on legend entries) // - user can interactively disable plot lines for improved overview and vertical scaling (click on legend entries) // - added zoom (mousewheel/pinch on plot) and pan capability (drag zoomed-in plot) // - saves over 4 KB in compiled BSB-LAN sketch

define USE_ADVANCED_PLOT_LOG_FILE // Compile CUNO/CUNX/modified MAX!Cube

extension.

define MAX_CUL

bool enable_max_cul = false; // enable or disable connection to CUNO/CUNX/modified MAX!Cube; byte max_cul_ip_addr[4] = {192,168,178,5}; // IP of CUNO/CUNX/modified MAX!Cube. Please use commas instead of dots!!! char max_device_list[20][11] = { // list of MAX! wall/heating thermostats that should be polled "KEQ0502326", // use MAX! serial numbers here which have to have exactly 10 characters "KEQ0505080" }; // defines the number of retries for the query command

define QUERY_RETRIES 3 // Setting bus pins and bus type byte bus_pins[2] =

{0,0}; //First value - RX pin, second value - TX pin. 0,0 - auto select (19,18 for Due, 16,17 for NodeMCU, 36,17 for Olimex EVB and 68,69 for Mega). uint8_t bus_type = 0; // set bus system at boot: 0 = BSB, 1 = LPB, 2 = PPS // BSB: // - 'own_address' sets own address, defaults to 0x42 (LAN in serial monitor) // - 'dest_address' sets destination address, defaults to 0 for heating system. // LPB: // - 'own_address and 'dest_address' set own and destination address (high nibble = segment, low nibble = device minus 1) // - defaults to 0x42 for own address and 0x00 for destination address, i.e. segment 4, device 3 for Arduino/BSB-LAN and segment 0, device 1 for heating system byte own_address = 0x42; byte dest_address = 0x00; // PPS: // - set 'pps_write' to "1" to enable writing to heater - only use this if there is no other room controller (such as QAA50/QAA70) active. bool pps_write = 0; byte QAA_TYPE = 0x53; // 0x53 = QAA70, 0x52 = QAA50, 0x5A = QAA10, 0x37 = QAA95, 0x66 = BMU, 0xEA = MCBA/REA70/DC225 /* Set the device family and device variant of your heating system. Only change this if you really know what you are doing!

Set fixed_device_family and fixed_device_variant to your device family and variant (parameters 6225 and 6226) here

if heating system is not running when Arduino is powered on. */ uint16_t fixed_device_family = 0; uint16_t fixed_device_variant = 0; // defines default flag for parameters // use "#define DEFAULT_FLAG FL_SW_CTL_RONLY" to control read/write functionality via configuration in web interface. // use "#define DEFAULT_FLAG 0" to make (almost) all parameters writeable // use #define DEFAULT_FLAG FL_RONLY to run the program always in read-only mode.
define DEFAULT_FLAG FL_SW_CTL_RONLY // include commands from

BSB_lan_custom.h to be executed at the end of each main loop //#define CUSTOM_COMMANDS /*

Check for new versions when accessing BSB-LAN's main page.

Doing so will poll the most recent version number from the BSB-LAN server.

In this process, it is unavoidable that your IP address will be transferred to the server, obviously.

We nevertheless mention this here because this constitutes as 'personal data' and this feature is therefore disabled by default.

Activating this feature means you are consenting to transmitting your IP address to the BSB-LAN server where it will be stored

for up to two weeks in the server's log files to allow for technical as well as abuse analaysis.

No other data (such as anything related to your heating system) is transmitted in this process, as you can see in the source code. */
define VERSION_CHECK

bool enable_version_check = false; #define ENABLE_ESP32_OTA boolean enable_ota_update = true; // "External" web server. Read files from SD-card. Only static content: html, js, css, jpg, etc. //#define WEBSERVER // Configuration will be stored in EEPROM // #define CONFIG_IN_EEPROM // Compile web-based configuration and EEPROM config store module extension.

define WEBCONFIG // Compile JSON-based configuration and EEPROM config

store module extension. // #define JSONCONFIG #define RGT_EMULATOR int rgte_sensorid[3][5] = {{0, 0, 0, 0, 0}, {0, 0, 0, 0, 0}, {0, 0, 0, 0, 0}}; //Temperature sensor program IDs for RGT1/PPS - RGT3. If zero then RGT will not be emulated. If more than one program set per RGT then average will be calculated and used. //Enable presence buttons and TWW/DHW push on selected pins. // Pins on Mega can be (Digital) 2, 3, 18, 19, 20, 21 // On Due any Digital pins can be selected excluding 12, 16-21, 31, 33, 53. // Make sure you aren't using pins which are already in use for sensors (default: 2, 3, 7) or change them accordingly.

define BUTTONS

uint8_t button_on_pin[4] = {0, 0, 0, 0}; //Order: TWW push, presence ROOM1, presence ROOM2, presence ROOM3 // Variables for future use: // Compile room unit replacement extension

define ROOM_UNIT

byte UdpIP[4] = {0,0,0,0}; // (destination IP address for sending UDP packets to, the room unit replacement of FHEM user @fabulous uses that) uint16_t UdpDelay = 15; // (interval in seconds to send UDP packets) // Compile off-site logger extension

define OFF_SITE_LOGGER

byte destinationServer[128] = ""; // URL string to periodically send values to an off-site logger uint16_t destinationPort = 80; // port number for abovementioned server uint32_t destinationDelay = 84600; // interval in seconds to send values /*

For Arduino Mega users:

If you use CONFIG_IN_EEPROM and WEBCONFIG modules then

you can enable I_DO_NOT_WANT_URL_CONFIG for saving flash memory (~1.2Kb).

This will disable configuration through URL commands (/A, /L, /P)

define I_DO_NOT_WANT_URL_CONFIG

Enable I_WILL_USE_EXTERNAL_INTERFACE for saving flash memory (~6,8Kb). /DG command will be disabled

define I_WILL_USE_EXTERNAL_INTERFACE

Enabling I_DO_NOT_NEED_NATIVE_WEB_INTERFACE will eliminate native web interface and save up to 13 Kb of flash memory.

/N[E] and /Q command still work

You can use this if you are using third-party software for BSB-LAN management. Do not forget to enable other required modules (JSONCONFIG, MQTT, WEBSERVER).

define I_DO_NOT_NEED_NATIVE_WEB_INTERFACE

*/ // By default, the following modules are disabled for the Arduino Mega2560 due to lack of memory. // This overwrites any definements above. // You are of course free to make changes here so that they fit your needs and the Mega's memory constraints.

if defined(AVR)

//#undef CONFIG_IN_EEPROM //#undef WEBCONFIG

undef JSONCONFIG

//#undef WEBSERVER

undef AVERAGES

undef DEBUG

undef IPWE

undef MQTT

undef MDNS_HOSTNAME

undef OFF_SITE_LOGGER

undef ROOM_UNIT

undef VERSION_CHECK

undef MAX_CUL

undef BME280

endif

/****/ /****/ / Settings - END / /****/ /****/ — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

mirkolenz commented 2 years ago

Sure, here is the log output:

In file included from /BSB_LAN/BSB_LAN.ino:836:
/BSB_LAN/BSB_LAN_EEPROMconfig.h:237:118: error: 'max_device_list' was not declared in this scope
   {CF_MAX_DEVICES,      0, CCAT_MAX,      CPI_TEXT,      CDT_MAXDEVICELIST,  OPT_FL_ADVANCED, CF_DEVICES_TXT, sizeof(max_device_list)}, //Need to call UpdateMaxDeviceList() before saving to EEPROM
                                                                                                                      ^~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN_EEPROMconfig.h:237:118: note: suggested alternative: 'mdns_service_exists'
   {CF_MAX_DEVICES,      0, CCAT_MAX,      CPI_TEXT,      CDT_MAXDEVICELIST,  OPT_FL_ADVANCED, CF_DEVICES_TXT, sizeof(max_device_list)}, //Need to call UpdateMaxDeviceList() before saving to EEPROM
                                                                                                                      ^~~~~~~~~~~~~~~
                                                                                                                      mdns_service_exists
/BSB_LAN/BSB_LAN.ino:673:33: error: 'max_device_list' was not declared in this scope
 #define MAX_CUL_DEVICES (sizeof(max_device_list)/sizeof(max_device_list[0]))
                                 ^~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN_EEPROMconfig.h:238:114: note: in expansion of macro 'MAX_CUL_DEVICES'
   {CF_MAX_DEVADDR,      0, CCAT_MAX,      CPI_NOTHING,   CDT_VOID,           OPT_FL_BASIC|OPT_FL_ADVANCED, NULL, MAX_CUL_DEVICES * sizeof(uint32_t)},
                                                                                                                  ^~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN.ino:673:33: note: suggested alternative: 'mdns_service_exists'
 #define MAX_CUL_DEVICES (sizeof(max_device_list)/sizeof(max_device_list[0]))
                                 ^~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN_EEPROMconfig.h:238:114: note: in expansion of macro 'MAX_CUL_DEVICES'
   {CF_MAX_DEVADDR,      0, CCAT_MAX,      CPI_NOTHING,   CDT_VOID,           OPT_FL_BASIC|OPT_FL_ADVANCED, NULL, MAX_CUL_DEVICES * sizeof(uint32_t)},
                                                                                                                  ^~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN.ino:673:57: error: 'max_device_list' was not declared in this scope
 #define MAX_CUL_DEVICES (sizeof(max_device_list)/sizeof(max_device_list[0]))
                                                         ^~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN_EEPROMconfig.h:238:114: note: in expansion of macro 'MAX_CUL_DEVICES'
   {CF_MAX_DEVADDR,      0, CCAT_MAX,      CPI_NOTHING,   CDT_VOID,           OPT_FL_BASIC|OPT_FL_ADVANCED, NULL, MAX_CUL_DEVICES * sizeof(uint32_t)},
                                                                                                                  ^~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN.ino:673:57: note: suggested alternative: 'mdns_service_exists'
 #define MAX_CUL_DEVICES (sizeof(max_device_list)/sizeof(max_device_list[0]))
                                                         ^~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN_EEPROMconfig.h:238:114: note: in expansion of macro 'MAX_CUL_DEVICES'
   {CF_MAX_DEVADDR,      0, CCAT_MAX,      CPI_NOTHING,   CDT_VOID,           OPT_FL_BASIC|OPT_FL_ADVANCED, NULL, MAX_CUL_DEVICES * sizeof(uint32_t)},
                                                                                                                  ^~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN.ino: In function 'uint8_t recognizeVirtualFunctionGroup(uint16_t)':
/BSB_LAN/BSB_LAN.ino:673:33: error: 'max_device_list' was not declared in this scope
 #define MAX_CUL_DEVICES (sizeof(max_device_list)/sizeof(max_device_list[0]))
                                 ^~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN.ino:1225:44: note: in expansion of macro 'MAX_CUL_DEVICES'
   else if (nr >= BSP_MAX && nr < BSP_MAX + MAX_CUL_DEVICES * 4) {return 5;} //20500 - 20699
                                            ^~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN.ino:673:33: note: suggested alternative: 'mdns_service_exists'
 #define MAX_CUL_DEVICES (sizeof(max_device_list)/sizeof(max_device_list[0]))
                                 ^~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN.ino:1225:44: note: in expansion of macro 'MAX_CUL_DEVICES'
   else if (nr >= BSP_MAX && nr < BSP_MAX + MAX_CUL_DEVICES * 4) {return 5;} //20500 - 20699
                                            ^~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN.ino: In function 'int findLine(uint16_t, uint16_t, uint32_t*)':
/BSB_LAN/BSB_LAN.ino:1274:13: error: 'max_device_list' was not declared in this scope
         if (max_device_list[(line - BSP_MAX) / 4][0] == 0) {  //device not set
             ^~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN.ino:1274:13: note: suggested alternative: 'mdns_service_exists'
         if (max_device_list[(line - BSP_MAX) / 4][0] == 0) {  //device not set
             ^~~~~~~~~~~~~~~
             mdns_service_exists
/BSB_LAN/BSB_LAN.ino: In function 'void generateConfigPage()':
/BSB_LAN/BSB_LAN.ino:2305:22: error: 'CF_LOGAVERAGES_TXT' was not declared in this scope
     printToWebClient(CF_LOGAVERAGES_TXT);
                      ^~~~~~~~~~~~~~~~~~
/BSB_LAN/BSB_LAN.ino:2305:22: note: suggested alternative: 'CF_LOGAVERAGES'
     printToWebClient(CF_LOGAVERAGES_TXT);
                      ^~~~~~~~~~~~~~~~~~
                      CF_LOGAVERAGES

exit status 1

Compilation error: 'max_device_list' was not declared in this scope

mirkolenz commented 2 years ago

Also, I just noticed that in my first config example, I uploaded the working version. So here is the one that resulted in the log output shown above:

/************************************************************************************/
/************************************************************************************/
/* Settings -   BEGIN                                                               */
/************************************************************************************/
/************************************************************************************/

// Upon first installation, rename this file from BSB_lan_config.h.default to BSB_lan_config.h and adjust settings accordingly
// Users who still use Arduino Mega2560 boards instead of Arduin Due: Please have a look at the very end of this configuration
// where certain modules are disabled by default due to limited flash memory.

/* Select language; so far German is the most complete, with English following.
 * Available languages are: Czech (CS), German (DE), Danish (DA), English (EN), Spanish (ES), Finnish (FI),
 * French (FR), Greek (EL), Hungarian (HU), Italian (IT), Dutch (NL), Polish (PL), Russian (RU), Swedish (SV),
 * Slovenian (SI) and Turkish (TR).
 * Incomplete languages will automatically be filled up with English translations first, and if no English translation
 * is available, fallback will take place to German.
*/
#define LANG EN

/*
Allow to initialize program configuration by reading settings from EEPROM
byte UseEEPROM = 0; // Configuration is read from this config file.
                    // Configuration can be stored in EEPROM but will not used while UseEEPROM is zero.
                    // Set zero for fallback startup in case EEPROM configuration is broken.
byte UseEEPROM = 1; // Configuration will be read from EEPROM. This is the default.
*/
byte UseEEPROM = 0;

/*
 *  Enter a MAC address, found either on the EthernetShield or use the one below.
 *  Change this if you have more than one BSB-LAN adapter in your LAN, so that there aren't any address conflicts.
 *  MAC address here only affects the LAN shield, it doesn't apply to the WiFi-ESP-solution.
*/
byte mac[6] = { 0x00, 0x80, 0x41, 0x19, 0x69, 0x90 };

/*
 * Initialize the Ethernet server library
 * with the IP address and port you want to use
 * (port 80 is default for HTTP):
*/

uint16_t HTTPPort = 80;
bool useDHCP = true;                 // Set to false if you want to use a fixed IP.
byte ip_addr[4] = {192,168,178,88};     // Please note the commas instead of dots!!!  Set useDHCP to true if you want DHCP.
byte gateway_addr[4] = {192,168,178,1}; // Gateway address. This is usually your router's IP address. Please note the commas instead of dots!!! Ignored if first value is 0.
byte dns_addr[4] = {192,168,178,1};     // DNS server. Please note the commas instead of dots!!! Ignored if first value is 0.
byte subnet_addr[4] = {255,255,255,0};  // Subnet address. Please use commas instead of dots!!! Ignored if first value is 0.

//#define WIFI                          // Activate this definement if you want to use WiFi. Note: MAC address can't be set individually.
char wifi_ssid[32] = "YourWiFiNetwork"; // enter your WiFi network name (SSID) here
char wifi_pass[64] = "YourWiFiPassword";// enter your WiFi password here
#define WIFI_SPI_SS_PIN 12              // defines SPI-SS pin for Arduino-ESP8266 connection

#define MDNS_SUPPORT                   // Advertises the hostname in the local network. Disable this if you don't want your device to be found under this name in your network.
char mDNS_hostname[32] = "BSB-LAN";

#define DEBUG         // Compile with verbose DEBUG module if defined
byte debug_mode = 1;  // Debug mode: 0 - disabled, 1 - send debug messages to serial interface, 2 - send debug messages to telnet client
byte verbose = 1;     // If set to 1, all messages on the bus are printed to debug interface
byte monitor = 0;     // Bus monitor mode. This is only necessary for in-depth debug sessions.
bool show_unknown = true; // true - show all parameters, false - hide unknown parameters from web display (parameters will still be queried and therefore take time!)

/* SECURITY OPTIONS
 * There are several options to control and protect access to your heating system. However, keep
 * in mind, that even activating all three options are no guarantee that a versatile intruder with
 * access to your (W)LAN won't be able to gain access. In any case, no encryption of data streams
 * is provided from the Arduino itself. Use VPN or a SSL proxy if that is a must for you and connect
 * the Arduino wired to the VPN server or SSL proxy. On the other hand, someone with this amount
 * of criminal activity will probably have it easier just to access your heating system face-to-face ;)
*/

/*
 * if PASSKEY length is non-zero, the URL has to contain the defined passkey as first element
 * e.g.
 * char PASSKEY[64] = "1234";
 * http://192.168.178.88/1234/                - to view the main website (don't forget the trailing slash!)
 * http://192.168.178.88/1234/K               - to list all categories
 * http://192.168.178.88/1234/8700/8740/8741  - to list parameters 8700, 8740 and 8741 in one request
*/
char PASSKEY[64] = "";

/* activate IP-address-based access.
You can set any ip address as trusted.
Not used if first byte is 0
*/
byte trusted_ip_addr[4] = {0,0,0,0};
byte trusted_ip_addr2[4] = {0,0,0,0};

/* Activate HTTP-Auth authentication to provide username/password based access. No encryption!
 * Credentials have to be entered in the form
 * User:Password
 */
//char USER_PASS[64] = "User:Password";
char USER_PASS[64] = "";      // HTTP-Auth will be disabled if USER_PASS string length is zero

// Compile module with one wire bus support.
#define ONE_WIRE_BUS
byte One_Wire_Pin = 0;         // Define the pin for one wire temperature sensors. 0 - disable oneWire bus

// Compile module with DHT temperature/humidity sensors support
#define DHT_BUS
// Define the pins for DHT temperature/humidity sensors (Up to 10)
uint8_t DHT_Pins[10] = {0};

// Compile module with BME280 temperature/humidity/pressure sensors support on I2C bus.
// Up to two sensors with 0x76 and 0x77 addresses.
#define BME280
byte BME_Sensors = 0; //Define number of BME280 sensors

// Compile module for calculation 24h averages for selected programs
#define AVERAGES
// Create 24h averages from these parameters and save data into averages.txt on SD-card.
int avg_parameters[40] = {
  8700,                         // Außentemperatur
  8326                          // Brenner-Modulation
};

/* Compile module for logging on SD-card.
Requires a FAT32-formatted Micro-SD card inserted into the Ethernet-Shield's card slot
Does: log bus telegrams to file
      log selected values to file
      store to SD and load selected 24h averages
      push selected values to an MQTT broker*/
#define LOGGER

// Use SD card adapter on ESP32-based boards instead of SPIFFS flash-based storage
#define ESP32_USE_SD

// Log "raw" bus telegrams. Data saved in journal.txt on SD-card.
// Telegrams logged upon boot:
// int logTelegram = LOGTELEGRAM_OFF; // nothing to log,
// int logTelegram = LOGTELEGRAM_ON;  // log all telegrams,
// int logTelegram = LOGTELEGRAM_ON + LOGTELEGRAM_UNKNOWN_ONLY;           // log unknown telegrams,
// int logTelegram = LOGTELEGRAM_ON + LOGTELEGRAM_BROADCAST_ONLY;         // log broadcast telegrams,
// int logTelegram = LOGTELEGRAM_ON + LOGTELEGRAM_UNKNOWNBROADCAST_ONLY;  // log unknown broadcast telegrams only;
int logTelegram = LOGTELEGRAM_OFF;

// Logging data from parameters
// Interval and list of parameters can be redefined through /L command during runtime
// Data will be written to "datalog.txt"
unsigned long log_interval = 60;  // Logging interval (to SD card and MQTT broker) in seconds
int log_parameters[40] = {
  8310, // Kesseltemperatur-Istwert (C)
  8314, // Rücklauftemperatur-Istwert (C)
  8316, // Abgastemperatur-Istwert (C)
  // 8323, // Gebläsedrehzahl (U/min)
  8325, // Aktuelle Gebläseansteuerung (%)
  8326, // Brennermodulation (%)
  8327, // Wasserdruck (-)
  // 8329, // Ionisationsstrom Istwert (mikroA)
  8700, // Aussentemperatur (C)
  8735, // Heizkreispumpe Drehzahl HK1 (%)
  8743, // Vorlauftemperatur Istwert Heizkreis 1 (C)
  // 8750, // Not in manual: Pump speed (%)
  8825, // Drehzahl Trinkwasserpumpe (%)
  8830, // Trinkwassertemperatur-Istwert
  // 8860, // Trinkwasserdurchfluss (l/min)
//  20000,                  // Spezialparameter: Brenner-Laufzeit Stufe 1
//  20001,                  // Spezialparameter: Brenner-Takte Stufe 1
//  20002,                  // Spezialparameter: Brenner-Laufzeit Stufe 2
//  20003,                  // Spezialparameter: Brenner-Takte Stufe 2
//  20004,                  // Spezialparameter: TWW-Laufzeit
//  20005,                  // Spezialparameter: TWW-Takte
//  20050,                  // Spezialparameter 20050-20099: 24h-Durchschnittswerte
//  20100,                  // Spezialparameter 20100-20299: DHT22-Sensoren 1-50
//  20300                   // Spezialparameter 20300-20499: DS18B20-Sensoren 1-100
//  20500                   // Spezialparameter 20500-20699: MAX!-Sensoren 1-50
};

// Compile MQTT extension: activate sending log_parameters to MQTT broker every log_interval seconds
#define MQTT
byte mqtt_mode = 1; // MQTT: 1 - send messages in plain text format, 2 - send messages in JSON format, 3 - send messages in rich JSON format. Use this if you want a json package of your logging information printed to the mqtt topic
// rich JSON payload will be of the structure: {"MQTTDeviceID": {"id": "parmeter number from log values", "name": "parameter name from logvalues", "value": "query result", "desc": "enum value description", "unit": "unit of measurement", "error", error code}}
byte mqtt_broker_ip_addr[4] = {1,1,1,1}; // MQTT broker ip address. Please use commas instead of dots!!!
char MQTTUsername[32] = "user";                 // Set username for MQTT broker here or set empty string if no username/password is used.
char MQTTPassword[32] = "pass";                 // Set password for MQTT broker here or set empty string if no password is used.
char MQTTTopicPrefix[32] = "bsblan";            // Optional: Choose the "topic" for MQTT messages here. In case of empty string, default topic name will be used

// Optional: Define a device name to use as header in json payload. In case of empty string, "BSB-LAN" will be used.
// This value is also used as a client ID towards the MQTT broker, change it if you have more than one BSB-LAN on your broker.
char MQTTDeviceID[32] = "bsblan";

// Logging mode: 0 - disabled, 1 - write values to SD card, 2 - write 24h averages to SD card, 4 - send values to MQTT, 8 -  send values to UDP. Can be conjunction of these values.
byte LoggingMode = 4; //CF_LOGMODE_SD_CARD | CF_LOGMODE_SD_CARD_24AVG | CF_LOGMODE_MQTT | CF_LOGMODE_UDP

// Compile IPWE extension

#define IPWE
bool enable_ipwe = true;  // true - activate IPWE extension (http://xxx.xxx.xxx.xxx/ipwe.cgi)
// Parameters to be displayed in IPWE extension
int ipwe_parameters[40] = {
  8310, // Kesseltemperatur-Istwert (C)
  8314, // Rücklauftemperatur-Istwert (C)
  8316, // Abgastemperatur-Istwert (C)
  // 8323, // Gebläsedrehzahl (U/min)
  8325, // Aktuelle Gebläseansteuerung (%)
  8326, // Brennermodulation (%)
  8327, // Wasserdruck (-)
  // 8329, // Ionisationsstrom Istwert (mikroA)
  8700, // Aussentemperatur (C)
  8735, // Heizkreispumpe Drehzahl HK1 (%)
  8743, // Vorlauftemperatur Istwert Heizkreis 1 (C)
  // 8750, // Not in manual: Pump speed (%)
  8825, // Drehzahl Trinkwasserpumpe (%)
  8830, // Trinkwassertemperatur-Istwert
  // 8860, // Trinkwasserdurchfluss (l/min)
};

// If you prefer to use the log file plotting (/DG) used in BSB-LAN 2.1.3, disable the following #define.
// Otherwise a newer implementation will be used that does require (automated) loading of an additional
// Javascript library off the internet (currently 204 KB), but offers the following improvements:
// - better legibility for value numbers with plot lines close to each other (mouseover on plot)
// - user can interactively highlight plot lines for improved overview (mouseover on legend entries)
// - user can interactively disable plot lines for improved overview and vertical scaling (click on legend entries)
// - added zoom (mousewheel/pinch on plot) and pan capability (drag zoomed-in plot)
// - saves over 4 KB in compiled BSB-LAN sketch
#define USE_ADVANCED_PLOT_LOG_FILE

// Compile CUNO/CUNX/modified MAX!Cube extension.
// #define MAX_CUL
// bool enable_max_cul = false;                // enable or disable connection to CUNO/CUNX/modified MAX!Cube;
// byte max_cul_ip_addr[4] = {192,168,178,5};     // IP of CUNO/CUNX/modified MAX!Cube. Please use commas instead of dots!!!
// char max_device_list[20][11] = {               // list of MAX! wall/heating thermostats that should be polled
//   "KEQ0502326",                                // use MAX! serial numbers here which have to have exactly 10 characters
//   "KEQ0505080"
// };

// defines the number of retries for the query command
#define QUERY_RETRIES  3

// Setting bus pins and bus type

byte bus_pins[2] = {0,0}; //First value - RX pin, second value - TX pin. 0,0 - auto select (19,18 for Due, 16,17 for NodeMCU, 36,17 for Olimex EVB and 68,69 for Mega).
uint8_t bus_type = 0;  // set bus system at boot: 0 = BSB, 1 = LPB, 2 = PPS
// BSB:
// - 'own_address' sets own address, defaults to 0x42 (LAN in serial monitor)
// - 'dest_address' sets destination address, defaults to 0 for heating system.
// LPB:
// - 'own_address and 'dest_address' set own and destination address (high nibble = segment, low nibble = device minus 1)
// - defaults to 0x42 for own address and 0x00 for destination address, i.e. segment 4, device 3 for Arduino/BSB-LAN and segment 0, device 1 for heating system
byte own_address = 0x42;
byte dest_address = 0x00;
// PPS:
// - set 'pps_write' to "1" to enable writing to heater - only use this if there is no other room controller (such as QAA50/QAA70) active.
bool pps_write = 0;
byte QAA_TYPE = 0x53;  // 0x53 = QAA70, 0x52 = QAA50, 0x5A = QAA10, 0x37 = QAA95, 0x66 = BMU, 0xEA = MCBA/REA70/DC225

/* Set the device family and device variant of your heating system. Only change this if you _really_ know what you are doing!
 * Set fixed_device_family and fixed_device_variant to your device family and variant (parameters 6225 and 6226) here
 * if heating system is not running when Arduino is powered on.
*/
uint16_t fixed_device_family = 0;
uint16_t fixed_device_variant = 0;

// defines default flag for parameters
// use "#define DEFAULT_FLAG FL_SW_CTL_RONLY" to control read/write functionality via configuration in web interface.
// use "#define DEFAULT_FLAG 0" to make (almost) all parameters writeable
// use #define DEFAULT_FLAG FL_RONLY to run the program always in read-only mode.
#define DEFAULT_FLAG FL_SW_CTL_RONLY

// include commands from BSB_lan_custom.h to be executed at the end of each main loop
//#define CUSTOM_COMMANDS

/*
 * Check for new versions when accessing BSB-LAN's main page.
 * Doing so will poll the most recent version number from the BSB-LAN server.
 * In this process, it is unavoidable that your IP address will be transferred to the server, obviously.
 * We nevertheless mention this here because this constitutes as 'personal data' and this feature is therefore disabled by default.
 * Activating this feature means you are consenting to transmitting your IP address to the BSB-LAN server where it will be stored
 * for up to two weeks in the server's log files to allow for technical as well as abuse analaysis.
 * No other data (such as anything related to your heating system) is transmitted in this process, as you can see in the source code.
*/
#define VERSION_CHECK
bool enable_version_check = false;

#define ENABLE_ESP32_OTA
boolean enable_ota_update = true;

// "External" web server. Read files from SD-card. Only static content: html, js, css, jpg, etc.
//#define WEBSERVER

// Configuration will be stored in EEPROM
// #define CONFIG_IN_EEPROM

// Compile web-based configuration and EEPROM config store module extension.
// #define WEBCONFIG

// Compile JSON-based configuration and EEPROM config store module extension.
// #define JSONCONFIG

#define RGT_EMULATOR
int rgte_sensorid[3][5] = {{0, 0, 0, 0, 0}, {0, 0, 0, 0, 0}, {0, 0, 0, 0, 0}}; //Temperature sensor program IDs for RGT1/PPS - RGT3. If zero then RGT will not be emulated. If more than one program set per RGT then average will be calculated and used.

//Enable presence buttons and TWW/DHW push on selected pins.
// Pins on Mega can be (Digital) 2, 3, 18, 19, 20, 21
// On Due any Digital pins can be selected excluding 12, 16-21, 31, 33, 53.
// Make sure you aren't using pins which are already in use for sensors (default: 2, 3, 7) or change them accordingly.
#define BUTTONS
uint8_t button_on_pin[4] = {0, 0, 0, 0}; //Order: TWW push, presence ROOM1, presence ROOM2, presence ROOM3

// Variables for future use:
// Compile room unit replacement extension
#define ROOM_UNIT
byte UdpIP[4] = {0,0,0,0}; // (destination IP address for sending UDP packets to, the room unit replacement of FHEM user @fabulous uses that)
uint16_t UdpDelay = 15;    // (interval in seconds to send UDP packets)

// Compile off-site logger extension
#define OFF_SITE_LOGGER
byte destinationServer[128] = "";   // URL string to periodically send values to an off-site logger
uint16_t destinationPort = 80;      // port number for abovementioned server
uint32_t destinationDelay = 84600;  // interval in seconds to send values

/*
 * For Arduino Mega users:
 *
 * If you use CONFIG_IN_EEPROM and WEBCONFIG modules then
 * you can enable I_DO_NOT_WANT_URL_CONFIG for saving flash memory (~1.2Kb).
 * This will disable configuration through URL commands (/A, /L, /P)
 * #define I_DO_NOT_WANT_URL_CONFIG
 *
 * Enable I_WILL_USE_EXTERNAL_INTERFACE for saving flash memory (~6,8Kb). /DG command will be disabled
 * #define I_WILL_USE_EXTERNAL_INTERFACE
 *
 * Enabling I_DO_NOT_NEED_NATIVE_WEB_INTERFACE will eliminate native web interface and save up to 13 Kb of flash memory.
 * /N[E] and /Q command still work
 * You can use this if you are using third-party software for BSB-LAN management. Do not forget to enable other required modules (JSONCONFIG, MQTT, WEBSERVER).
 * #define I_DO_NOT_NEED_NATIVE_WEB_INTERFACE
 */

// By default, the following modules are disabled for the Arduino Mega2560 due to lack of memory.
// This overwrites any definements above.
// You are of course free to make changes here so that they fit your needs and the Mega's memory constraints.
#if defined(__AVR__)
//#undef CONFIG_IN_EEPROM
//#undef WEBCONFIG
#undef JSONCONFIG
//#undef WEBSERVER
#undef AVERAGES
#undef DEBUG
#undef IPWE
#undef MQTT
#undef MDNS_HOSTNAME
#undef OFF_SITE_LOGGER
#undef ROOM_UNIT
#undef VERSION_CHECK
#undef MAX_CUL
#undef BME280
#endif
/************************************************************************************/
/************************************************************************************/
/* Settings -   END                                                                 */
/************************************************************************************/
/************************************************************************************/

1coderookie commented 2 years ago

Besides the fact, that I can't say anything about the problem itself, I'm just wondering if that config.h really is the latest version - because this (new) entry

#define UDP_LOG_PORT 6502 // fixed here, not configurable via web interface

is missing between the two lines with the definements #define LOGGER and #define ESP32_USE_SD.

So I'm wondering if you maybe use an older config.h and just updated the .ino file itself..?

Also: I wonder why you commented out the whole MAX-stuff block, instead of only just deactivating the definement like this:

// Compile CUNO/CUNX/modified MAX!Cube extension.
//#define MAX_CUL
bool enable_max_cul = false;                // enable or disable connection to CUNO/CUNX/modified MAX!Cube;
byte max_cul_ip_addr[4] = {192,168,178,5};     // IP of CUNO/CUNX/modified MAX!Cube. Please use commas instead of dots!!!
char max_device_list[20][11] = {               // list of MAX! wall/heating thermostats that should be polled
  "KEQ0502326",                                // use MAX! serial numbers here which have to have exactly 10 characters
  "KEQ0505080"
};

-> maybe that causes any problems..?

Maybe it's worth a try to download the latest BSB-LAN zipfile again and then try again to compile with those two deactivated definements..?

fredlcore commented 2 years ago

Good thinking, @1coderookie! Exactly, the commented out variables are obviously the reason for these errors. It is perfectly enough to just set enable_max_cul to false, no need to even comment out the #define MAX_CUL line (although that is permissible). This would only get you a little bit more free flash memory for which there is no use currently anyway.

mirkolenz commented 2 years ago

I updated to version 2.1 by diffing my old config with the new one. Could be the I missed this new UDP setting by accident. I will double check that later. All remaining files were used from the GitHub download.

Regarding the MAX_CUL block: I did not consider only commenting out the define part, that could solve one issue. However, the compilation still fails if WEBCONFIG is commented out.

mirkolenz commented 2 years ago

I will incorporate all suggestions later and update whether the problem still persists. Thanks to all of you!

fredlcore commented 2 years ago

Some definements were optional in the past or have to be activated alternatively to each other, but as I said, the ability to disable definements still comes from a time where a) flash memory was (much) more limited and b) no web-based configuration existed. Nowadays, it is enough to disable the function by using the respective variable or just do it in the webinterface.

1coderookie commented 2 years ago

So I just tried it with the latest version (with Due) and only deactivated the definement #define WEBCONFIG (= //#define WEBCONFIG) and I can confirm that compiling doesn't work:

/home/db/BSB-LAN-master/BSB_LAN/BSB_LAN.ino: In function 'void generateConfigPage()':
BSB_LAN:2277:22: error: 'CF_LOGAVERAGES_TXT' was not declared in this scope
     printToWebClient(CF_LOGAVERAGES_TXT);
                      ^
BSB_LAN:2284:89: error: 'prognrBuf' was not declared in this scope
         printFmtToWebClient(PSTR("%s - %s: %d<BR>\r\n"), printProgNR(avg_parameters[i], prognrBuf), lookup_descr(avg_parameters[i]), BSP_AVERAGES + i);//outBuf will be overwrited here
                                                                                         ^
BSB_LAN:2297:73: error: 'prognrBuf' was not declared in this scope
       printFmtToWebClient(PSTR("%s - "), printProgNR(log_parameters[i], prognrBuf);
                                                                         ^
/home/db/BSB-LAN-master/BSB_LAN/BSB_LAN.ino: In function 'void generateJSONwithConfig()':
BSB_LAN:2938:58: error: 'printMAClistToWebClient' was not declared in this scope
        printMAClistToWebClient((byte *)variable, cfg.size);
                                                          ^
BSB_LAN:2946:60: error: 'printProglistToWebClient' was not declared in this scope
        printProglistToWebClient((float *)variable, cfg.size);
                                                            ^
BSB_LAN:2950:58: error: 'printDHTlistToWebClient' was not declared in this scope
        printDHTlistToWebClient((byte *)variable, cfg.size);
                                                          ^
BSB_LAN:2954:58: error: 'printMAXlistToWebClient' was not declared in this scope
        printMAXlistToWebClient((byte *)variable, cfg.size);
                                                          ^
Mehrere Bibliotheken wurden für "EthernetUdp.h" gefunden
 Benutzt: /home/db/Arduino/libraries/Ethernet
 Nicht benutzt: /home/db/arduino-1.8.8/libraries/Ethernet
 Nicht benutzt: /home/db/arduino-1.8.8/libraries/Ethernet
 Nicht benutzt: /home/db/arduino-1.8.8/libraries/Ethernet
 Nicht benutzt: /home/db/arduino-1.8.8/libraries/Ethernet
Bibliothek SPI in Version 1.0 im Ordner: /home/db/.arduino15/packages/arduino/hardware/sam/1.6.12/libraries/SPI  wird verwendet
Bibliothek Wire in Version 1.0 im Ordner: /home/db/.arduino15/packages/arduino/hardware/sam/1.6.12/libraries/Wire  wird verwendet
Bibliothek Ethernet in Version 2.0.0 im Ordner: /home/db/Arduino/libraries/Ethernet  wird verwendet
exit status 1
'CF_LOGAVERAGES_TXT' was not declared in this scope

To make it clear: everything else within config.h is set as default - as I said, I only deactivated that one definement.

dukess commented 2 years ago

Thanks to everyone, the problem is more or less clear, as soon as there is time, I will try to fix it.

1coderookie commented 2 years ago

"More or less clear "- I like that one ;) Thanks!

dukess commented 2 years ago

Just notes: CF_LOGAVERAGES_TXT was removed in https://github.com/fredlcore/BSB-LAN/commit/858a8425095f977db70ebe52b5bfc2edd41c69dd Should to return back. Forgot to declare variable 'char prognrBuf[8];' in line ~2274-2275

Functions printMAClistToWebClient(), printProglistToWebClient(), printDHTlistToWebClient(), printMAXlistToWebClient() should be enclosed with

#if defined(JSONCONFIG) || defined(WEBCONFIG)
...
#endif

dukess commented 2 years ago

Did fix for issue.

fredlcore commented 2 years ago

Thanks!

fredlcore / BSB-LAN

[BUG] Cannot compile sketch if certain extensions are not defined #476

define LANG EN /*

define WIFI_SPI_SS_PIN 12 // defines SPI-SS pin for Arduino-ESP8266

define ONE_WIRE_BUS

define DHT_BUS

define BME280

define AVERAGES

define LOGGER // Use SD card adapter on ESP32-based boards instead of

define ESP32_USE_SD // Log "raw" bus telegrams. Data saved in journal.txt

define MQTT

define USE_ADVANCED_PLOT_LOG_FILE // Compile CUNO/CUNX/modified MAX!Cube

define MAX_CUL

define QUERY_RETRIES 3 // Setting bus pins and bus type byte bus_pins[2] =

define DEFAULT_FLAG FL_SW_CTL_RONLY // include commands from

define VERSION_CHECK

define WEBCONFIG // Compile JSON-based configuration and EEPROM config

define BUTTONS

define ROOM_UNIT

define OFF_SITE_LOGGER

define I_DO_NOT_WANT_URL_CONFIG

define I_WILL_USE_EXTERNAL_INTERFACE

define I_DO_NOT_NEED_NATIVE_WEB_INTERFACE

if defined(AVR)

undef JSONCONFIG

undef AVERAGES

undef DEBUG

undef IPWE

undef MQTT

undef MDNS_HOSTNAME

undef OFF_SITE_LOGGER

undef ROOM_UNIT

undef VERSION_CHECK

undef MAX_CUL

undef BME280

endif