fredlcore / BSB-LAN

LAN/WiFi interface for Boiler-System-Bus (BSB) and Local Process Bus (LPB) and Punkt-zu-Punkt Schnittstelle (PPS) with a Siemens® controller used by Elco®, Brötje® and similar heating systems
222 stars 84 forks source link

Fix for Issue #513. Correct timestamps for log files. Fix for new SdFat #514

Closed dukess closed 1 year ago

dukess commented 1 year ago

Fix for Issue https://github.com/fredlcore/BSB-LAN/issues/513 Adaptive (int/float) program numbers printing for web interface, MQTT, UDP/file logging. Due: callback for SdFat library added for setup correct timestamps on log files. ESP32: TimeLib library wrapper added. This wrapper can't be used with TimeLib in same time on ESP32. Wrapper will allow to set correct timestamps on log files.

mirkolenz commented 1 year ago

Thank you for coming up with a solution that fast. From what I understood in the issue, you propose the following:

I hope I got that right. While I like the solution overall, I think it may be confusing to users: The web interface always shows the trailing zero, meaning that there is a mismatch if one tries to copy the parameter IDs to their config.

At the same time, I am not sure what the best solution would be here. Duplicate messages are not good and a new setting for this is overkill. I just wanted to raise awareness for this fact.

dukess commented 1 year ago

Yes, your meaning correct. I changed program numbers behavior for web interface.

fredlcore commented 1 year ago

@dukess: Could you say also how you changed program numbers in the web interface? Just in case @1coderookie has screenshots in the manual that then are no longer correct.

mirkolenz commented 1 year ago

@dukess Great, that seems like the most elegant solution 😄

dukess commented 1 year ago

@fredlcore it would be look like 2.0 version: изображение

изображение

fredlcore commented 1 year ago

That looks great, thanks! Does this span across all modes (web interface, MQTT, JSON)?

dukess commented 1 year ago

Now everything seems to be ready.

fredlcore commented 1 year ago

Great, thanks a lot!