fredlcore / BSB-LAN

LAN/WiFi interface for Boiler-System-Bus (BSB) and Local Process Bus (LPB) and Punkt-zu-Punkt Schnittstelle (PPS) with a Siemens® controller used by Elco®, Brötje® and similar heating systems
220 stars 83 forks source link

[BUG] Just FYI because for old version: lines 2505 and 2504 in cmdtbl are mixed up #550

Closed dukess closed 1 year ago

dukess commented 1 year ago

In old BSB_LAN_defs.h two lines in cmdtbl array are mixed up:

{0x053D1AE1,  CAT_KESSEL,           VT_LITERPERMIN,   2505,  STR2505,  0,                    NULL,         FL_OEM,       DEV_ALL}, // Schwelle Durchflussdetektion
{0x053D0FE8,  CAT_KESSEL,           VT_SECONDS_SHORT5,2504,  STR2504,  0,                    NULL,         DEFAULT_FLAG, DEV_ALL}, // Baxi Luna Platinum+ Min Einschaltzeit Schalter

which cause infinite loop for category 34. It should be

{0x053D0FE8,  CAT_KESSEL,           VT_SECONDS_SHORT5,2504,  STR2504,  0,                    NULL,         DEFAULT_FLAG, DEV_ALL}, // Baxi Luna Platinum+ Min Einschaltzeit Schalter
{0x053D1AE1,  CAT_KESSEL,           VT_LITERPERMIN,   2505,  STR2505,  0,                    NULL,         FL_OEM,       DEV_ALL}, // Schwelle Durchflussdetektion
fredlcore commented 1 year ago

Yes, the problem is that I cannot change files in past releases - or is there a way to do so?

dukess commented 1 year ago

You can create new branch from last commit with "old version" and leave it for bugfixes.

fredlcore @.***> 6 марта 2023 г. 00:34:03 написал:

Yes, the problem is that I cannot change files in past releases - or is there a way to do so? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

fredlcore commented 1 year ago

Thanks!