fredlcore / BSB-LAN

LAN/WiFi interface for Boiler-System-Bus (BSB) and Local Process Bus (LPB) and Punkt-zu-Punkt Schnittstelle (PPS) with a Siemens® controller used by Elco®, Brötje® and similar heating systems
220 stars 83 forks source link

Stop serving client that is already gone #598

Closed DE-cr closed 9 months ago

DE-cr commented 9 months ago

...at least for potentially long lasting actions, e.g. /D or /K24. This avoids unnecessarily blocking bsb-lan for other tasks (including new client requests).

Succesfully tested on ESP32 with wifi connection, using the url commands given above. I consider this ready for merging.

DE-cr commented 9 months ago

P.s. now also addressing /QD handling. (Tested on my system.)

fredlcore commented 9 months ago

Great idea, thanks! Does this also mean that you can abort let's say a long query of parameters (such as /0-9999) by hitting the "Stop" button on the browser and start a new query right after? Because that has often confused users who were wondering why BSB-LAN was still not responding for minutes until the query in the background was completed.

DE-cr commented 9 months ago

Yes, tested right now. :)

DE-cr commented 9 months ago

Btw, I've done my testing by calling the url commands that usually take a long time, then immediately going back to the previous page in the browser (alt + left), which cancels the client connection and creates a new one.

fredlcore commented 9 months ago

Great, that's really helpful!