fredlcore / BSB-LAN

LAN/WiFi interface for Boiler-System-Bus (BSB) and Local Process Bus (LPB) and Punkt-zu-Punkt Schnittstelle (PPS) with a Siemens® controller used by Elco®, Brötje® and similar heating systems
225 stars 84 forks source link

Change some GUI strings to address SD card vs. flash memory ambiguity #644

Closed DE-cr closed 6 months ago

DE-cr commented 6 months ago

With reference to https://github.com/fredlcore/BSB-LAN/issues/632#issuecomment-1999089017

Moved storage location config to general section, as it applies for both logging and webserver file system. Please note: I don't know if this requires additional measures to address possible shifts in EEPROM storage locations!

Changed some GUI strings to address SD card vs. flash memory ambiguity.

Removed "ESP32" from GUI string for energy saving, as other ESP32 only strings don't have that prefix either (OTA, SD/flash).

Adjusted whitespace in one code area, so that comments properly align regardless of tab width setting.

fredlcore commented 6 months ago

Please move the storage settings back to their original place as this is where it thematically belongs best. While it also affects the webserver, hardly any configuration file that I received for debugging purposes had this feature enabled.

DE-cr commented 6 months ago

Done. New change description is then:

~~Moved storage location config to general section, as it applies for both logging and webserver file system. Please note: I don't know if this requires additional measures to address possible shifts in EEPROM storage locations!~~

Changed some GUI strings to address SD card vs. flash memory ambiguity.

Removed "ESP32" from GUI string for energy saving, as other ESP32 only strings don't have that prefix either (OTA, SD/flash).

Adjusted whitespace in one code area, so that comments properly align regardless of tab width setting.

DE-cr commented 6 months ago

Btw, I use the webserver functionality, but only to store the javascript libraries required for /DG locally. This just fyi.

fredlcore commented 6 months ago

Thanks!