search

fredlcore / BSB-LAN

LAN/WiFi interface for Boiler-System-Bus (BSB) and Local Process Bus (LPB) and Punkt-zu-Punkt Schnittstelle (PPS) with a Siemens® controller used by Elco®, Brötje® and similar heating systems
225 stars 84 forks source link

Include watermark in all html pages #646

Closed DE-cr closed 5 months ago

DE-cr commented 5 months ago

As an improvement (?) to https://github.com/fredlcore/BSB-LAN/pull/645, e.g. Bildschirmfoto vom 2024-04-08 21-09-43 I would have preferred to have the logo stay at the same window position when scrolling, but unfortunately using background-attachment:fixed leads to the watermark being cut off when scrolling past the initial window's size. Using height:200% would have solved this (for /C and other long pages I tried), but then you could scroll down well past the content of pages that fit into the initial window.

Tested with the usual browsers (Ubuntu:Firefox,Chromium; Win11:Edge; Android:Chrome,Silk; Mac:Safari), at various window sizes.

fredlcore commented 5 months ago

Thanks, but I think in this case, it's sufficient to have the logo on the top of the page (otherwise it might seem the project is a bit too self-centered ;) ). With the graph, I have seen it here and there that people post it and some take a screenshot of the whole screen, but some just take one of the graph, so that's why the watermark here is really helpful. However what I was wondering whether it is possible to offer a "Download" button so that one could download a rendered version of the graph withouth having to do a screenshot?

DE-cr commented 5 months ago

:D understood.

Graph download could be either SVG or bitmap (e.g. PNG). The former might be doable even without additional JavaScript libraries, but the files could become rather large with many data points rendered. The latter would probably require an additional library. Personally, I don't see why a bitmap download function would be worth the implementation, as screenshots are so easy to do (except on MacOS, where I haven't been able to memorize the key combination required to trigger one). An SVG download could be somewhat helpful, as it would allow zooming in on details. However, you'd still lose all the interactive functionality of the live plot - which you'd keep by doing a /D download and loading it in scripts/BSB-LAN_datalog-viewer.html. Btw, do you want a watermark included there as well?

fredlcore commented 5 months ago

Yes, you're right, then we just keep it as it is. PS: Screenshot on Mac is command+Shift+4 :)