Simplify code in BSB-LAN_datalog-viewer.html

fredlcore / BSB-LAN

LAN/WiFi interface for Boiler-System-Bus (BSB) and Local Process Bus (LPB) and Punkt-zu-Punkt Schnittstelle (PPS) with a Siemens® controller used by Elco®, Brötje® and similar heating systems

216 stars 83 forks source link

Simplify code in BSB-LAN_datalog-viewer.html #648

Closed DE-cr closed 3 months ago

DE-cr commented 3 months ago

Contrary to the BSB-LAN executable, we don't use an existing black svg here, but are creating our own one. Therefore we don't have to go through hoops to achieve opacity; we can just render the svg lighter.

Sorry for not thinking of this while https://github.com/fredlcore/BSB-LAN/pull/647 was still open. Feel free to ignore this change proposal and just close the PR.

fredlcore commented 3 months ago

Sorry, but what does it do now, and why should I (not) merge it?

DE-cr commented 3 months ago

It just makes the code easier.

You might want to discard it to

avoid a merge that only makes the code of a rarely used (?) script easier to understand
keep the code as close as possible to https://github.com/fredlcore/BSB-LAN/blob/master/BSB_LAN/html_strings.h (there, it has to be more complicated, see my initial comment here above)

fredlcore commented 3 months ago

That's fine, thanks!