search

fredleblanc / roundabout

A 3D Turntable jQuery Plugin.
645 stars 205 forks source link

Fix animations when using jQuery >= 1.7.2 and jQuery UI #121

Open RobCherry opened 11 years ago

RobCherry commented 11 years ago

Fixes https://github.com/fredhq/roundabout/issues/61 https://github.com/fredhq/roundabout/issues/86 https://github.com/fredhq/roundabout/issues/87 and https://github.com/fredhq/roundabout/issues/106

quietasice commented 11 years ago

jQuery 1.8.3 and jQuery ui 1.9.2 animation didn't work :(

DonDi1989 commented 10 years ago

Also it doesn't work with jQuery UI 1.10.3. Is there any solution ?

jonaslu commented 10 years ago

I got it working with jQuery UI 1.10.3:

First, apply the fix reply #95 in so the "focus" event fires again reply 3 by @jellever

Then change the following 3 lines (line 693 - 697 in version https://github.com/fredhq/roundabout/blob/d8cc98ccc0e214514cfe76fe4c1a9d8a99a50c6b/jquery.roundabout.js)

if (true) {
  newBearing = passedData.start + ((bearing - passedData.start) * newBearing);
}

// newBearing = methods.normalize.apply(null, [newBearing]);

The newBearing was set to 0 with without these changes. Did this for a quick workaround - it requires more digging to fix the root cause.

kitsunde commented 10 years ago

@jonaslu Just ran into this and that hack works great, thanks. :)

JorisLambrechts commented 10 years ago

@jonaslu thanks, it worked (even without the fix in #95) I'm using jquery 1.10.1 and jquery UI 1.10.3