fredleblanc / roundabout

A 3D Turntable jQuery Plugin.
645 stars 205 forks source link

jQuery UI 1.8.23 => animation broken! #72

Open SexySale opened 11 years ago

SexySale commented 11 years ago

jQuery UI version from 1.8.23 till 1.9.0 animation broken! (jQuery 1.7.2. version)

noremacstew commented 11 years ago

I've found the same issue occurs with jQuery 1.8.2 and jQuery UI 1.9.1. I fixed it by changing the following line:

(around line 693, commented out easeOutBack check) if (methods.compareVersions.apply(null, [$().jquery, "1.7.2"]) >= 0 /&& !($.easing["easeOutBack"])/) {

next-direction commented 11 years ago

Thanks noremacstew, this solved the problem for me too.

WLL70 commented 11 years ago

line 693, in which file? I searched for

if (methods.compareVersions.apply(null, [$().jquery, "1.7.2"]) >= 0 /&& !($.easing["easeOutBack"])/) {

in jquery, ui and roundabout and did not find it

noremacstew commented 11 years ago

For me it is line 693 of jquery.roundabout.js (v2.4.2).

The PHP comment you quoted around for the easeOutBack check was the change I made to fix the issue. Try searching for:

if (methods.compareVersions.apply(null, [$().jquery, "1.7.2"]) >= 0 && !($.easing["easeOutBack"]))

In my copy there is also this comment just above that line:

// fixes issue #24, animation changed as of jQuery 1.7.2 // also addresses issue #29, using easing breaks "linear"

Searching for those comments might lead you to the line I was referring to. Hope that helps!

WLL70 commented 11 years ago

I can't thank you enough for this fix!

blacroix commented 11 years ago

Works for me on jquery-ui-1.9.2.custom.min.js (full) ; jquery-1.8.3.min.js and roundabout 2.4.2

Thanks a lot !