Closed acdupont closed 1 year ago
Just some formatting failures that need fixing:
https://github.com/fredo-dedup/JSONSchema.jl/actions/runs/4568925572/jobs/8064573055?pr=41
Just some formatting failures that need fixing:
https://github.com/fredo-dedup/JSONSchema.jl/actions/runs/4568925572/jobs/8064573055?pr=41
I'm not sure where these errors are coming from, I only changed text such as Vector
to AbstractVector
and such, I did not change any formatting. Output such as:
-function build_id_map!(id_map::AbstractDict, schema::AbstractVector, uri::URIs.URI)
+function build_id_map!(
+ id_map::AbstractDict,
+ schema::AbstractVector,
+ uri::URIs.URI,
+)
is confusing because the version of function build_id_map!
in my codebase is one line. Is this output saying the one line should be replaced with the 5 lines then, rather than saying it was replaced but is a formatting error?
I'm not sure where these errors are coming from, I only changed text such as Vector to AbstractVector and such, I did not change any formatting
The formatter enforces a maximum line length:
The new lines are too long. I've fixed in the recent commits.
JSON3 uses
AbstractArray
,AbstractDict
in the implementation of it's parsed json types. To add support for JSON3JSONSchema
, it seems all that needs to be done is to change the corresponding concrete types to abstract types.The first and only test so far for these changes is the following example:
Schema
json
REPL reproducing behavior
REPL on PR branch