fredo509 / js-capstone

2 stars 0 forks source link

Group capstone: set up your Kanban board #6

Open fredo509 opened 1 year ago

fredo509 commented 1 year ago

Project link

In this project we are two developers work on this project : @ellyboi as student B and @fredo509 as student A.

danmainah commented 1 year ago

Hi @fredo509 and @Ellyboi ,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

✔️ Good Issue with the correct Description

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

TedLivist commented 1 year ago

STATUS: CHANGES REQUIRED ♻️ ♻️

Hi @fredo509 and @Ellyboi,

Good job so far! ✔️ Tasks are properly assigned However, there are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

julie-ify commented 1 year ago

Hi @fredo509 and @Ellyboi,

Highlights!

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Status: Approved ✔️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.