search

fredokun / cl-jupyter

An enhanced interactive Shell for Common Lisp (based on the Jupyter protocol)
BSD 2-Clause "Simplified" License
199 stars 29 forks source link

large PR from Shafmeister group #38

Closed fredokun closed 6 years ago

fredokun commented 6 years ago

I'm trying this PR for now in a separate widget branch

drmeister commented 6 years ago

That sounds great!

The main thing was to get the hooks for cl-jupyter-widgets into cl-jupyter so that we can switch back to your repo as the definitive cl-jupyter repo. Currently we are using github.com/drmeister/cl-jupyter.git and it should be identical to your new cl-jupyter 'widget' branch with maybe a few more docstrings.

fredokun commented 6 years ago

After testing a little bit the PR I will probably put it as master. I also intend to merge the completion work (branch completion) in another PR. Then it would be nice if you can use it as a basis for further work...

drmeister commented 6 years ago

Our approaches to Tab and Shift-Tab completion are probably too different to merge them with the other PR that you have. Feel free to drop ours (either or both) if they aren't as well thought out as the other one. We really just need the cl-jupyter-widgets hooks. The Shift-Tab completion can support HTML if I read the standard correctly. That means that we could have HTML links in the info that is displayed - which would be really nice. We could link to the CLHS for instance.