search

fredokun / cl-jupyter

An enhanced interactive Shell for Common Lisp (based on the Jupyter protocol)
BSD 2-Clause "Simplified" License
199 stars 29 forks source link

We've made several enhancements to cl-jupyter #42

Closed drmeister closed 6 years ago

drmeister commented 6 years ago

First - I merged cl-jupyter/master with the code in this pull request - so AFAIK it contains everything in cl-jupyter/master.

  1. I've upgraded to jupyter protocol 5.3.
  2. I've fixed a large problem with the way cl-jupyter sent and received messages. It is now sending and receiving arrays of bytes instead of strings. This fixes the unicode error that happened right at the beginning when cl-jupyter started up and it avoids coercing byte arrays that jupyter sends and expects from the kernel to strings when that is not allowed.
  3. I added a lot of logging that can be turned on and off because jupyter is an evolving protocol and we need the logging to see differences.
fredokun commented 6 years ago

Thanks... I will try to backport the non-widget enhancements and fixes to the master branch...

drmeister commented 6 years ago

Excellent, thank you. I've been moving kind of quickly developing the code and the code isn't as tidy as I'd like. Mostly I've had to insert a lot of logging macro invocations (logg macro) to figure out what is going on. I figure that since the jupyter protocol is still under rapid development that we will need the logging statements in the future so I left them in.

On Wed, Aug 29, 2018 at 7:50 AM Frederic Peschanski < notifications@github.com> wrote:

Merged #42 https://github.com/fredokun/cl-jupyter/pull/42 into widget.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fredokun/cl-jupyter/pull/42#event-1815429129, or mute the thread https://github.com/notifications/unsubscribe-auth/AGdaVLebjFxmRgNxTTct67iJo7yLxxpiks5uVoAQgaJpZM4WMmki .

-- Christian Schafmeister Professor, Chemistry Department Temple University