search

fredrikburmester / streamyfin

A Jellyfin client build with Expo
Mozilla Public License 2.0
710 stars 19 forks source link

Consider using predefined thumbnails for the Libary view instead of those passed by jellyfin #101

Closed yihaolee85 closed 3 weeks ago

yihaolee85 commented 3 weeks ago

Describe the bug Couldn't reopen #73, library names are repeated in the Library view in the new 0.8.1 release. It looks like the large words are embedded in the image downloaded from Jellyfin, and the smaller is text overlayed on Streamyfin. It also causes overlap for the "Collections" text.

In landscape the image height is too low causing the top and bottom of the words to be cut off.

To Reproduce Steps to reproduce the behavior:

  1. Go to Library, you can see the issue
  2. Rotate to landscape and you can see the 2nd issue

Screenshots IMG_1193 IMG_1194

Smartphone (please complete the following information):

retardgerman commented 3 weeks ago

That's actually not really a problem with the app. This was also happening to me. Turns out, Jellyfin automatically generates a thumbnail for the library and burns the name of the library into it. That is then also displayed in the app.

Unfortunately, there is no option on jellyfin's side to prevent this if you want to use automatic metadata.

yihaolee85 commented 3 weeks ago

That's actually not really a problem with the app. This was also happening to me. Turns out, Jellyfin automatically generates a thumbnail for the library and burns the name of the library into it. That is then also displayed in the app.

Unfortunately, there is no option on jellyfin's side to prevent this if you want to use automatic metadata.

Yes, maybe then the small text can be removed? Or do you mean there is a case where it is possible that the thumbnail for the library won't contain the name? If so, maybe we can consider putting the Library name below the thumbnail like how it is for movie posters?

retardgerman commented 3 weeks ago

Maybe we could think about using a pre-selected image for the buttons and not passing the thumbnail of the library to the buttons. So the small text could be left as it is.

yihaolee85 commented 3 weeks ago

Yes, either way works, as they both solve the problem

fredrikburmester commented 3 weeks ago

I don't have the text burned on top of the image, that's why i added the small text.

IMG_9D401C42F494-1

Maybe i can check what type of library image is used and render the text accordingly. Gonna investigate.

fredrikburmester commented 3 weeks ago

This is solved in a future release by letting uses choose the look.