search

fredrikekre / jlpkg

A command line interface (CLI) for Pkg, Julia's package manager.
MIT License
92 stars 4 forks source link

Check validity of arguments, better error messages. #6

Closed fredrikekre closed 5 years ago

fredrikekre commented 5 years ago

This segfaults Julia 1.0 so should not be merged until that is fixed, or until Julia 1.0 support is dropped.

fredrikekre commented 5 years ago

Hmm. Tests segfault on master with Julia 1.0.4 (https://github.com/fredrikekre/jlpkg/runs/196739829) even though there have been no changes to Julia code from https://github.com/fredrikekre/jlpkg/runs/148565014 so maybe this PR is not the problem.

codecov-io commented 5 years ago

Codecov Report

Merging #6 into master will decrease coverage by 4.47%. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6      +/-   ##
=======================================
- Coverage   89.47%   85%   -4.48%     
=======================================
  Files           2     2              
  Lines          19    20       +1     
=======================================
  Hits           17    17              
- Misses          2     3       +1
Impacted Files Coverage Δ
src/cli.jl 0% <0%> (ø) :arrow_up:
src/jlpkg.jl 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8a77b8...a8a1163. Read the comment docs.