Open GoogleCodeExporter opened 9 years ago
Thanks for the contribution!
If you haven't already, you should fill out a CLA before this patch can be
reviewed. We can then add your name to the contributors list:
http://code.google.com/p/playn/source/browse/CONTRIBUTORS
Original comment by mmast...@gmail.com
on 8 Jan 2012 at 12:18
Thanks for your reply. I have submitted a signed CLA now.
Original comment by par.ekl...@gmail.com
on 8 Jan 2012 at 8:51
I submitted my comments on your patch.
Note that it appears your email address isn't configured correctly in your
.gitconfig (not sure if Google Code uses that email for notifications). You can
fix them like so:
$ git config --global user.name "Firstname Lastname"
$ git config --global user.email "your_email@youremail.com"
Original comment by mmast...@gmail.com
on 10 Jan 2012 at 5:33
Thanks for your help and feedback.
I have now made changes as per your comments:
http://code.google.com/r/pareklund-playn/source/detail?r=c3ccb5beef0661f7fa49759
d58edd1202d0f0548
Next time I will make sure to fix basic things such as these before committing.
I guess my eagerness to contribute got the better of me. ;-\
Original comment by par.ekl...@gmail.com
on 11 Jan 2012 at 11:42
I merged upstream changes into my local clone before committing the changes but
it appears that I never managed to commit the upstream changes into my remote
clone. That has now been amended. Sorry for that (as stated, I am quite new to
git). Please let me know if you want me to do anything more related to this.
Original comment by par.ekl...@gmail.com
on 12 Jan 2012 at 5:02
Original issue reported on code.google.com by
par.ekl...@gmail.com
on 3 Dec 2011 at 4:05