search

fredsa / playn

Cross platform game library for N≥4 platforms
0 stars 1 forks source link

Code review request #109

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes on this branch:
Adds ?render=canvas to the HTML platform. Preserves ?renderer=[dom,gl], making
'canvas' the default for non-gl capable browsers.

First step towards fixing issue 96.

When reviewing my code changes, please focus on:
Missing cases around transforms, image-layer repeats, and the like.

After the review, I'll merge this branch into:
/trunk

http://code.google.com/r/joelgwebber-playn/source/detail?r=aa057e64465f810392bea
64ac51685b464c77217

Original issue reported on code.google.com by jgw@google.com on 19 Dec 2011 at 9:59

GoogleCodeExporter commented 9 years ago 
LGTM. It runs all my games and random tests properly, and I read through the 
code and didn't spot anything that looked incorrect or terrifying. :)

Original comment by m...@samskivert.com on 19 Dec 2011 at 11:07

GoogleCodeExporter commented 9 years ago 
Works perfectly on stuff over here so far. 

For a very simple game, runs at ~5 fps in landscape on iPad, ~10fps in 1/2 
portrait. Same game reportedly runs smoothly on an iPad 2.

Original comment by mmast...@gmail.com on 19 Dec 2011 at 11:17

GoogleCodeExporter commented 9 years ago 
Thanks, guys, I just committed it. Let me know if you run into any trouble.

Original comment by joelgwebber on 20 Dec 2011 at 3:45

GoogleCodeExporter commented 9 years ago

Original comment by jgw@google.com on 20 Dec 2011 at 3:46