fredsa / playn

Cross platform game library for N≥4 platforms
0 stars 1 forks source link

Command-line generated skeleton contains a typo #129

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.Generate new project using the following command:
mvn archetype:generate -DarchetypeGroupId=com.googlecode.playn 
-DarchetypeArtifactId=playn-archetype -DarchetypeVersion=1.0.3
2.Run `ant compile-html`.

What is the expected output? What do you see instead?
Buildfile: /home/mbait/src/gwt-projects/hotapex/build.xml

-download-maven-ant:

-init-maven-ant:

-prepare:

-prepare-html:

-prep-webapp:
    [mkdir] Created dir: /home/mbait/src/gwt-projects/hotapex/target/webapp
     [copy] Copying 5 files to /home/mbait/src/gwt-projects/hotapex/target/webapp

-prepare-java:

compile:
    [mkdir] Created dir: /home/mbait/src/gwt-projects/hotapex/target/classes
    [javac] Compiling 2 source files to /home/mbait/src/gwt-projects/hotapex/target/classes
     [copy] Copying 1 file to /home/mbait/src/gwt-projects/hotapex/target/classes

-compile-html:
    [javac] Compiling 1 source file to /home/mbait/src/gwt-projects/hotapex/target/classes

compile-html:

BUILD FAILED
/home/mbait/src/gwt-projects/hotapex/build.xml:124: The <java> type doesn't 
support nested text data ("-->").

What version of the product are you using? On what operating system?
playn-1.0.3, Apache Ant 1.8.1, Gentoo Linux

Please provide any additional information below.
Sources 
https://github.com/mbait/hotapex/commit/846e5325292bc0a48fafe814e40400d2f14db18a

Apparently this is just a typo. The following patch fixes the issue:
diff --git a/build.xml b/build.xml
index 2379093..cdfcd99 100644
--- a/build.xml
+++ b/build.xml
@@ -131,7 +131,7 @@
         <path refid="html.classpath"/>
       </classpath>
       <jvmarg value="-Djava.awt.headless=true"/>
-      <arg value="-style"/><arg value="${gwt.style}"/>-->
+      <arg value="-style"/><arg value="${gwt.style}"/>
       <arg value="-war"/>
       <arg value="${target.dir}/webapp"/>
       <arg value="${html.classname}"/>

Original issue reported on code.google.com by ASolov...@gmail.com on 5 Feb 2012 at 11:03

GoogleCodeExporter commented 9 years ago
Fixed in ba5c06574f0a69701912e15f4910dd6ca34054bd.

Original comment by m...@samskivert.com on 6 Feb 2012 at 1:02