search

fredsa / playn

Cross platform game library for N≥4 platforms
0 stars 1 forks source link

Code review request #142

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes on this branch:
Implements the Java backend in terms of LWJGL rather than Java2D. This makes 
rendering much faster, and eliminates aliasing artifacts in transformed images.

When reviewing my code changes, please focus on:
This duplicates a *lot* of code from the Android backend (JavaGLContext and 
JavaShader). I really want to eliminate this duplication ASAP (with both the 
Android and HTML backends) but that's beyond the scope of one patch, methinks.

Known issues:
- Text: Text in the Showcase and Atlantis looks somewhat funky. I believe this 
is a combination of the choice of font, with the fact that we're losing LCD 
smoothing when rendering to a texture. I'm open to ideas if anyone knows of a 
solution to this problem.
- Running from Maven: I've updated the java pom to pull in lwjgl and its native 
deps. I have not yet, however, updated the launch configuration to properly put 
them on -Dlibrary.path. I'll need to fix this before committing.

After the review, I'll merge this branch into:
/trunk

Diff:
http://code.google.com/r/jgw-playn-work/source/detail?r=e93faa99e58df244cbf6232d
167b0025a2177f54&name=lwjgl

Original issue reported on code.google.com by joelgwebber on 23 Feb 2012 at 6:42

GoogleCodeExporter commented 9 years ago 
Updated diff with tests passing (some issues remain launching samples -- 
working on that now):

http://code.google.com/r/jgw-playn-work/source/detail?r=1d3db9dbb2f3cee92802643a
912277e0a902e622&name=lwjgl

Original comment by joelgwebber on 27 Feb 2012 at 4:22

GoogleCodeExporter commented 9 years ago 
In JavaPointer class there is no check listener is null or not.

Original comment by werdn...@gmail.com on 25 Mar 2012 at 3:34

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
For SEO purposes, the error for not having the system property is
Exception in thread "main" java.lang.UnsatisfiedLinkError: no lwjgl in 
java.library.path

Fix: Add VM arg -Djava.library.path=${project_loc}/target/natives
Make sure to run mvn -f java/pom.xml test if your natives folder has not been 
generated

Original comment by Ja...@wetheinter.net on 9 Jun 2012 at 10:49