fredsa / playn

Cross platform game library for N≥4 platforms
0 stars 1 forks source link

Added link to Game Loop wiki in Game.java file #196

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes on this branch:

Added link to Game Loop wiki in Game.java file.  (Trying to knock off some of 
the low hanging documentation todos.)

https://code.google.com/r/kirkkohler-playn/source/detail?r=af41d6ab310c6ab80f6f0
accfbbe4ca1bb9bafba

When reviewing my code changes, please focus on:

https://code.google.com/r/kirkkohler-playn/source/diff?spec=svnaf41d6ab310c6ab80
f6f0accfbbe4ca1bb9bafba&r=af41d6ab310c6ab80f6f0accfbbe4ca1bb9bafba&format=side&p
ath=/core/src/playn/core/Game.java

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by kirkkoh...@gmail.com on 23 Jul 2012 at 8:21

GoogleCodeExporter commented 9 years ago
This is nice, but it would be ten times easier for me to just apply the diff 
than to do the annoying shenanigans necessary to merge your patch on Google 
Code. Oh how I wish Google Code had not added Git support just in time to 
prevent us from hosting PlayN on Github, which would have made my life much 
easier.

If you want credit for the commit, send me a pull request on Github 
(https://github.com/threerings/playn) and I'll merge it there (where it's 
trivial) and push it back upstream along with all of my other changes.

Original comment by m...@samskivert.com on 23 Jul 2012 at 4:07

GoogleCodeExporter commented 9 years ago
I didn't realize the effort involved with using Google Code's git support.  I'm 
not concerned with the credit but the experience.  I'll attempt the doing a 
pull request on Github and see how that goes.  

If I hit any roadblocks, I'll just request you drop in the change in your local 
environment.

Do you think it is worth mentioning on this wiki (CheckoutReviewCommit) a 
different process for minor changes?

Original comment by kirkkoh...@gmail.com on 23 Jul 2012 at 9:04

GoogleCodeExporter commented 9 years ago
It's mainly that I have to add a remote to your clone, then pull in your 
changes, then merge your change, then delete your remote (lest I end up with 
dozens of remotes).

On Github, if your pull request is trivial (like this one), I can just click a 
button right on the page that lists the pull request and it's merged. Or more 
likely, I can issue a single Git command to slurp your pull request into my 
repository and push it back to merge it, since I don't like the merge commit 
that the standard "accept pull request" button generates.

Anyway, I should update the CheckoutReviewCommit page with the alternative 
Github approach, because 99% of the enhancements to PlayN originate on my 
Github fork, and are merged back upstream periodically.

Original comment by m...@samskivert.com on 23 Jul 2012 at 9:14

GoogleCodeExporter commented 9 years ago
Alright, I sent a pull request on github for this change.  

https://github.com/threerings/playn/pull/8

Original comment by kirkkoh...@gmail.com on 24 Jul 2012 at 7:50