search

fredsa / playn

Cross platform game library for N≥4 platforms
0 stars 1 forks source link

POM improvements that enable autodetection of GWT nature in Eclipse #48

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes on this branch:
To enable the GWT Eclipse plugin to autodetect that our html and flash samples 
are GWT projects and should be configured as such.

When reviewing my code changes, please focus on:
https://github.com/threerings/playn/commit/31731d804dd1dc1d1c15eb22f184a2f2d5a2d
4b2

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by samskiv...@gmail.com on 9 Sep 2011 at 4:27

GoogleCodeExporter commented 9 years ago 
LGTM

I went through the setup process on a completely fresh box and it worked!

I confirmed that the "Maven Integration for WTP" plugin is required (from 
http://download.jboss.org/jbosstools/updates/m2eclipse-wtp)

There are errors on the generated projects about the war source directory 
(e.g., playn-showcase-html/src/main/webapp) being missing, but we can get those 
in a follow-on patch.

Original comment by pdr@google.com on 10 Sep 2011 at 12:46

GoogleCodeExporter commented 9 years ago 
Committed as 5fa0f4e0f03cd3c89196b837936ec6429643b715.

Original comment by samskiv...@gmail.com on 12 Sep 2011 at 5:44