Code review: Fix Java net().post() function: Success callback missing.

fredsa / playn

Cross platform game library for N≥4 platforms

0 stars 1 forks source link

Code review: Fix Java net().post() function: Success callback missing. #61

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Purpose of code changes on this branch:
Fixing the post() function return value.

http://code.google.com/r/yohcop-playn/source/detail?r=91523076a9e09d9e2a1273eb05
0dbb3e75e47097

(Sorry for not using the template, but either the templates functionality was 
removed, or it is accessible only to members of the project. I only have access 
to Summary and Description field....)

Original issue reported on code.google.com by yoh...@gmail.com on 18 Sep 2011 at 4:06

GoogleCodeExporter commented 9 years ago

Original comment by charlie....@gmail.com on 18 Sep 2011 at 8:07

Added labels: Type-Review
Removed labels: Type-Defect

GoogleCodeExporter commented 9 years ago

LGTM, thank you for the fix.

Committed as r91523076a9e0

Original comment by pdr@google.com on 18 Sep 2011 at 11:46

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

I just confirmed that non-members weren't able to use the review request 
template. I've switched it so that everyone should be able to now. Apologies 
for the confusion.

Original comment by pdr@google.com on 18 Sep 2011 at 11:47