fredsa / playn

Cross platform game library for N≥4 platforms
0 stars 1 forks source link

Make Json.Writer fluent #74

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes on this branch:

All of the modification methods of Json.Writer now 'return this' for easy 
chaining. That allows

    writer.object().
      key("foo").value("bar").
      key("baz"),value(7).
      endObject();

instead of

    writer.object();
    writer.key("foo");
    writer.value("bar");
    writer.key("baz");
    writer.value(7);
    writer.endObject();

When reviewing my code changes, please focus on:

https://github.com/threerings/playn/commit/b6cdf4a1e57551657582d6c32f43f67ca2af4
95d

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by charlie....@gmail.com on 3 Oct 2011 at 9:07

GoogleCodeExporter commented 9 years ago
LGTM. We're slowly achieving fluency across the board.

Original comment by samskiv...@gmail.com on 2 Nov 2011 at 5:45

GoogleCodeExporter commented 9 years ago
Pushed in 5fa8abb

Original comment by charlie....@gmail.com on 2 Nov 2011 at 6:47