Code review request

[GoogleCodeExporter]

Purpose of code changes on this branch:
Replace HtmlGraphicsDom with HtmlGraphicsCanvas. I've been meaning to do this 
for ages -- the DOM implementation is quirky as hell on some browsers (and in 
certain edge-cases, like heavily-scaled background images). It's also never 
performed better than Canvas on most modern browsers.

Once this is committed, it will be a lot easier to fix 
http://code.google.com/p/playn/issues/detail?id=96, which will in turn allow us 
to clean up the [Image Canvas Surface][Layer] stuff a bit.

http://code.google.com/r/jgw-playn/source/detail?r=912534015694fc589eeba8880e144
d0aaa7f90c9

When reviewing my code changes, please focus on:
Correctness of the implementation, especially nested transforms. It seems to 
work correctly on every sample I've tried, and I believe it's correct, but you 
never know with this stuff.

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by jgw@google.com on 21 Nov 2011 at 1:55

• Blocking: #96

[GoogleCodeExporter]

Original comment by jgw@google.com on 21 Nov 2011 at 1:55

[GoogleCodeExporter]

I don't have time to look deeply at the moment, but there are some problems 
with transforms. I'm seeing things rendered at weird positions. I'm also seeing 
funny behavior with repeating images.

I'll dig into these issues when I get a chance, but I just wanted to let you 
know that they're there. You can reproduce them by running the Atlantis code 
(https://github.com/threerings/atlantis) and comparing the Java backend 
behavior to the new HTML Canvas backend behavior:

% git clone git://github.com/threerings/atlantis.git
% mvn test -Ptest-java
% mvn package
% mvn test -Ptest-html

Original comment by m...@samskivert.com on 23 Nov 2011 at 12:08

[GoogleCodeExporter]

Le 22 novembre 2011 19:08, <playn@googlecode.com> a �crit :

Sorry I've been sitting on this forever. I wanted to put it on hold until
we came up with a more general plan for the graphics architecture (that
other thread I started a few days ago). I have Atlantis compiling (and the
bug reproduced), and I'll resurrect this patch in some form as soon as that
discussion sorts out. I'll also add a visual test case to cover whatever's
going wrong with Atlantis.

Original comment by jgw@google.com on 12 Dec 2011 at 4:54

[GoogleCodeExporter]

Original comment by m...@samskivert.com on 22 Apr 2012 at 10:57

• Changed state: Done