search

fredvs / uos

United Open-libraries of Sound. United procedures for open-source audio libraries. For FPC/Lazarus/fpGUI/MSEgui.
Other
136 stars 27 forks source link

* Memory Leak on open MP3 (Every time i call mpg123_close i need to c… #18

Closed peruginia closed 6 years ago

peruginia commented 6 years ago

in AddFromMemoryStream if passed TypeAudio=-1 after try to open the file with sndfile if failed try with mpg123, opus and so on..

Delphi Rad studio 10.2 compatibility

fredvs commented 6 years ago

Hello Alessandro.

I will check your code today.

Many thanks.

Write you later.

Fre;D

fredvs commented 6 years ago

Re-hello Alessandro. Wow you did lot of work.

I think I will need much more time to check all.

Write you asap.

Fre;D

peruginia commented 6 years ago

unfortunately the delphi compiler is not so compatible ... with Lazarus 1.8 and delphi 10.2 with .mp3 and .ogg works very well ...

fredvs commented 6 years ago

Hello Alessandro.

I committed your changes for the memory leak, many thanks: commit 0ba7081

But for the Delphi-compatibility patches, nothing works any more using fpc for Linux-FreeBSD 64/32 on my system... ;-(

Fre;D

peruginia commented 6 years ago

the problem can be in any changed ifdef or in the change of IPAIODataIOInterface.. the big change is in indenting for undestand the code.. i can put the changes in your code with small change.. i think it's less than 200 lines of code...

fredvs commented 6 years ago

Hello Alessandro.

Yes. I agree, the code of uos is difficult to understand sometimes. uos was done by different developers and some have different habits.

For example IPAIODataIOInterface comes from uos_dsp_utils done by Andrew Haines. Andrew is a excellent developer (one of the best I know) and he uses original tricks.

If you was able to compile uos for Delphi ---> Wow. And then sure that some "$ifdef" will do uos fpc+Delphi compatible too.

Huh... if you can do it, it will be a new age for uos.

Fre;D