fredwu / crawler

A high performance web crawler / scraper in Elixir.
939 stars 91 forks source link

Inspect error reason before logging #10

Closed rhnonose closed 6 years ago

rhnonose commented 6 years ago

I was getting a (Protocol.UndefinedError) protocol String.Chars not implemented for {:already_registered, #PID} error when re-running the crawler, so I added a Kernel.inspect/1 call when logging the error in the default parser.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 2d2b831a2044292f824e4e9c6ad0d36f5b6ef482 on rhnonose:master into 1fb5bfdc67f973b3ff0118d9475bc50f1d6d7b71 on fredwu:master.

fredwu commented 6 years ago

Thanks @rhnonose! Could you please take a look at the codeclimate issue and wrap the logger argument in a fn? Thanks! :)

rhnonose commented 6 years ago

@fredwu done 🙂