plug_cowboy dependency - Githubissues

fredwu / crawler

A high performance web crawler / scraper in Elixir.

945 stars 91 forks source link

plug_cowboy dependency #22

Closed phereford closed 5 years ago

phereford commented 5 years ago

Hi @fredwu .

Thank you so much for this awesome (and popular) library! One quick question:

Is the plug_cowboy dependency used in the library outside of testing?

I can't quite find it being used in the library. If not, would you be ok for me to create a PR moving that dependency to the :test environment only?

fredwu commented 5 years ago

Hi @phereford, to be honest I don't really remember, if you could test it out in non-test envs to make sure it doesn't break anything that'd be awesome! ❤️

Awlexus commented 5 years ago

Would it be possible to also update the dependency to version 2? It is causing some conflicts in phoenix 1.4 umbrella projects

phereford commented 5 years ago

@awlexus sure! Sorry for the delay here.

fredwu commented 5 years ago

Closing thanks to @phereford's PR.

Although, I've tried to update plug_cowboy to v2 but it breaks the test suite and I couldn't figure out why from a few glances.