search

fredwu / crawler

A high performance web crawler / scraper in Elixir.
939 stars 91 forks source link

Moved `plug_cowboy` to test env #23

Closed phereford closed 5 years ago

phereford commented 5 years ago

I tested this where Mix.env == :dev and was successfully able to crawl pages. The test suite passes as well.

At the moment, this is not a mergeable PR. As commented by issue #22 , I will update the test dependency to ~> 2.0 but that involves altering the test suite due to changes to cowboy.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 99.425% when pulling e7e33ce88cf4fae4ce23597f63a6ea471bb129ec on phereford:master into 05cead2ee800181921c8955254b87debb6d47d1d on fredwu:master.

fredwu commented 5 years ago

Thanks!