search

fredwu / crawler

A high performance web crawler / scraper in Elixir.
945 stars 91 forks source link

update floki dep #27

Closed happysalada closed 4 years ago

happysalada commented 4 years ago

just trying to fix the deprecation warning with latest floki

warning: deprecation: parse the HTML with parse_document or parse_fragment before using find/2
  (floki 0.25.0) lib/floki.ex:208: Floki.find/2
  (crawler 1.1.0) lib/crawler/parser.ex:109: Crawler.Parser.do_parse_links/4
  (crawler 1.1.0) lib/crawler/parser.ex:95: Crawler.Parser.parse/1
  (crawler 1.1.0) lib/crawler/worker.ex:32: Crawler.Worker.handle_cast/2
  (stdlib 3.11) gen_server.erl:637: :gen_server.try_dispatch/4

I haven't changed the mix.exs file, I wasn't sure if you like the custom formatting, or if you were ok with just using the elixir formatter. I'm not sure you even want to update that dependency.

Let me know if you need anything

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.003%) to 99.429% when pulling 7ba678115bf9e9ad23774c51efd51403a4632b4a on happysalada:master into 9637e0377ee1f73b3c71cd21fbe8818b08dbd4a3 on fredwu:master.

fredwu commented 4 years ago

Thanks!

happysalada commented 4 years ago

Wow that was fast! Thanks