Closed cdesch closed 7 years ago
Hi @cdesch, thanks for the PR! To be honest though, I don't feel a lot of value adding these boilerplate instructions as they are largely identical for every Elixir package... I might refine it later on when the project grows bigger though.
Thanks for your contribution anyway! 💜
That is fair. It is up to you. I added them as it helps those whole are new to the elixir community, and hopefully to avoid opening simple getting started issues like I did.
On Wed, Aug 23, 2017, 09:05 Fred Wu notifications@github.com wrote:
Hi @cdesch https://github.com/cdesch, thanks for the PR! To be honest though, I don't feel a lot of value adding these boilerplate instructions as they are largely identical for every Elixir package... I might refine it later on when the project grows bigger though.
Thanks for your contribution anyway! 💜
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fredwu/crawler/pull/4#issuecomment-324324028, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJt804gYpRCj44BJD0kIcCvCQqXVtYfks5sbCOwgaJpZM4O8qHv .
Adding some base instructions to readme