fredwu / jquery-endless-scroll

Endless/infinite scrolling/pagination.
http://fredwu.github.com/jquery-endless-scroll/
837 stars 176 forks source link

It is a bug when i use div #45

Open metadata1984 opened 10 years ago

metadata1984 commented 10 years ago

consider the flowing example with endless-scroll version 1.8.0 <div id="mylist" class="row"> <div style="height:150px;float:left;"> <div>0</div> </div> </div> <script > $("#mylist").endlessScroll({ fireOnce: false, fireDelay: 10, insertAfter:'div.endless_scroll_content:last', content: function(i,p,d){ console.log(i,p,d); return '<div>'+p+'</div>' } }); </script>

Then i run my example.i found the srouce html code is : <div class="endless_scroll_content" data-page="1"> <div style="height:150px;float:left;"> <div>1</div> </div> <div class="endless_scroll_content" data-page="2"> <div style="height:150px;float:left;"> <div>2</div> </div> </div> </div>

i found the jquery.endless-scroll.js in line 160. if (defaults.insertAfter === null) { return this.options.insertAfter = "" + container + " div:last"; }

the defaults.insertAfter is aways null. so the content aways insert after "div.endless_scroll_inner_wrap div:last"

It is a bug? Tnx.

kanesee commented 9 years ago

I found the same issue. If the list contains a div, this plugin does not work.

The simple fix/hack is to comment out line 112 // this.setInsertPositionsWhenNecessary();

Harshit369 commented 8 years ago

@kanesee thanx! that worked, but now its necessary to pass both insertBefore and insertAfter.