search

fredyvonvinet / ANTLR4-Plugins-for-NetBeans

NetBeans plugins for ANTLR 4 enabling to integrate ANTLR grammar files in standard NetBeans projects (ant-based or Maven-based).
9 stars 11 forks source link

Fix for Issue #60 #61

Open sgparry opened 6 years ago

Chris2011 commented 6 years ago

If our PRs will not merge, I suggest you to fork it, what you already did and make a new version.

Chris2011 commented 6 years ago

Offtopic: Maybe you can provide PRs to this plugin: https://gitlab.com/mcheung63/netbeans-antlr because it is more active.

sgparry commented 6 years ago

Peter Cheung's plugin is good, but lacks the ANT build support that this plugin has. I do not think that a ANT build task has to be as complex as this one though. Why does it need to fully parse the actual ANTLR files? If FYV does not reply in a few weeks, I will create new repo - a straight fork is not enough because the history as-is is contaminated with lots of CRLFs and is fragmented with different folders for each version of the plugin. This defeats the purpose of Git. My repo will have all FYV's commits but applied to single folder and with corrected line-endings. I will also update to share one code base between multiple NB versions too - currently you have to make same the change three times. It will take a lot of work.