free-audio / clap-plugins

MIT License
64 stars 10 forks source link

should example plugins respect/implement note velocity? #16

Closed dbadb closed 1 year ago

dbadb commented 1 year ago

This is more a point of clarification.

A quick grep through the code shows that no-one is calling VoiceModule::velocity(). I see that there is a _velocityParam in adsr-module and that this is controlled via its vel parameter, but afaict there is no connect between note.velocity and this parameter.

I'm also seeing that the reference clap-host implementation seems to drop MIDI velocity.

Is this known/expected?

Thanks!

-- edit -- I now see that the onNoteOn message delivers the note.velocity to the adsr. Not yet sure why it doesn't seem to have an effect.

-- edit 2 -- And I now see that the /amp/vel parameter controls the velocity sensitivity. The default value makes the effect very subtle. It's possible that this is the same/similar issue as to why I velocity doesn't seem to effect Vital or Surge XT ...

(closing this issue, sorry for the noise).