Closed dbadb closed 1 year ago
The current implementation seems to map key 72 to 440Hz. According to SPN, key 69 should produce 440Hz. If this is intended to show how we can implement alternate tunings, then perhaps a code-comment is called for? Otherwise, I think this is a bug.
return 440 * tuningToRatio(key - 12 * 6);
should be ?
return 440 * tuningToRatio(key - 69);
Good catch!
abique
commented
1 year ago
The current implementation seems to map key 72 to 440Hz. According to SPN, key 69 should produce 440Hz. If this is intended to show how we can implement alternate tunings, then perhaps a code-comment is called for? Otherwise, I think this is a bug.
should be ?