search

free-audio / clap-wrapper

Wrappers for using CLAP in other plugin environments
MIT License
107 stars 17 forks source link

FIx _plugin->_ext._gui can be null on GUI-less plugins #265

Closed djowel closed 2 months ago

djowel commented 2 months ago

auval crashes with segmentation fault on GUI-less AU plugins.

baconpaul commented 2 months ago

Thanks!

But I think this is the same change I pushed to next a couple of weeks ago (along with a couple of other protections). Your change is the third one here right? https://github.com/free-audio/clap-wrapper/commit/dbe33d8a14e7567ffe24ca38307855acc3ded5df

baconpaul commented 2 months ago

@defiantnerd perhaps we should do a next -> main sweep sooner rather than later to pick up that change if it is the same (and merge this and then do said if this is a case I missed)

djowel commented 2 months ago

Thanks!

But I think this is the same change I pushed to next a couple of weeks ago (along with a couple of other protections). Your change is the third one here right? dbe33d8

Right. I wasn't aware of next. Should I be working on that branch instead of main?

baconpaul commented 2 months ago

Ideally we would sweep next to main with some regularity at a release point. We are trying to keep main stable and next as the dev branch

in this case I was just 2 weeks ahead of you in finding the bug

which you use really depends on your desire to have almost ready commits in your code path

defiantnerd commented 2 months ago

We should close this PR and bring next to main, since it already contains this fix, also on two other places..

baconpaul commented 2 months ago

I just synced next and main and tagged main as v0.10.0.

As well as ARA support and other fixes, that means main now includes the expanded version of this fix.

Thanks!