search

free-audio / clap-wrapper

Wrappers for using CLAP in other plugin environments
MIT License
107 stars 17 forks source link

Removing timer.cpp in newer VST3 SDK releases breaks linux build #266

Closed mtytel closed 2 months ago

mtytel commented 2 months ago

If you use a newer (3.7.9) or later vst3 sdk, then the removal of timer.cpp actually breaks the build. It worked for me when I left timer.cpp included with the newer vst3 sdk builds.

https://github.com/free-audio/clap-wrapper/blob/497f40a7580a2f6326fa06691f39aa3d7e0e78a7/cmake/base_sdks.cmake#L137

baconpaul commented 2 months ago

Sigh. OK I wonder if there is a cmake-time way to check the version. The problem is timer.cpp throws a bunch of warnings and errors in older SDKs.

mtytel commented 2 months ago

I think you retrieve the vst3 sdk version in cmake earlier. I can make a pull request if you want.

baconpaul commented 2 months ago

Oh you are correct, we do so about 15 lines above

so a

if (${SDK_VERSION} VERSION_LESS 3.7.9) around that line seems right to me.

If you could do a PR that'd be great, otherwise I can run it through tomorrow.

mtytel commented 2 months ago

https://github.com/free-audio/clap-wrapper/pull/269

defiantnerd commented 2 months ago

this looks good for me.

baconpaul commented 2 months ago

yup all merged. Thanks matt!