search

free-audio / clap-wrapper

Wrappers for using CLAP in other plugin environments
MIT License
107 stars 17 forks source link

Don't set MSVC to static runtime. #268

Closed mtytel closed 2 months ago

mtytel commented 2 months ago

https://github.com/free-audio/clap-wrapper/issues/267

baconpaul commented 2 months ago

So in this case, I think we should set it if it is not otherwise set don't you?

That is, if it is set to nothing set it to static.

I agree overriding the plugin author is aggravating but people use this as a top level cmake also. Can we if-test it ahead of time?

mtytel commented 2 months ago

If you include other cmake directories before clap-wrapper I think you'll get a conflict then and force the plugin dev to set it to DLL or static lib in their project anyway. Maybe if this was a full plugin framework it should set it but as a library that's probably included with other libraries I feel like it should just take the default.

baconpaul commented 2 months ago

Right. So the problem is we have two use cases

Users like you and me use it as a subordinate library to our project Users like u-he use it as a standalone to build a wrapper configured to dynaload their remote clap

That's why leaving it unset seems like a tough path for users in the second case. See what I mean?

The top level cmake here does do stuff with command lines basically.

Lemme google a bit and ponder.

baconpaul commented 2 months ago

I dealt with this conditionally in 48861ec so am going to close this PR.