free-audio / clap-wrapper

Wrappers for using CLAP in other plugin environments
MIT License
123 stars 20 forks source link

Wrapper sets `_host->version` to the plugin version not the host version #287

Closed baconpaul closed 1 month ago

baconpaul commented 3 months ago

In short circuit I construct my clap about screen this way (in my local branch - merging soon)

engine->runningEnvironment =
        "Clap-First " + std::string(h->name) + " " + std::string(h->version);

where h is my clap_host_t * passed in at construction. Fine.

The CLAP in bitwig shows this

Screenshot 2024-08-14 at 9 47 09 AM

The VST3 wrapped in bitwig though shows this

Screenshot 2024-08-14 at 9 47 25 AM

(0.7.225.0 is my plugin version number)

and the AUv2 wrapped in logic shows the same

Screenshot 2024-08-14 at 9 48 00 AM

(once I merge #286 to remove the specious -wrapper string)

so I think we need to go and use the protocols to find the running host version and report it if possible. Or at least report the clap wrapper version rather than the plugin version.

baconpaul commented 3 months ago

Note that the AUv2 adds (6029) which is the logic application bundle to the host name before the (CLAP-as-AUv2)

And we probably want some build option to make those terser perhaps?

defiantnerd commented 3 months ago

Those strings are actually only in debug builds.

baconpaul commented 3 months ago

Are you sure? I think you are confusing the plugin name with the clap _host->name

https://github.com/free-audio/clap-wrapper/blob/48861ecf472fe2cbcd67478e3f5f0dabe9e5785c/src/detail/auv2/auv2_base_classes.h#L462

that's not debug guarded

https://github.com/free-audio/clap-wrapper/blob/48861ecf472fe2cbcd67478e3f5f0dabe9e5785c/src/wrapasvst3.cpp#L1083

and neither is that. And I just did a release build and the screen for the VST3 was unchanged

baconpaul commented 3 months ago

I think the right solution here is probably a clap wrapper host information extension. Let me ponder that a bit.