free-audio / clap-wrapper

Wrappers for using CLAP in other plugin environments
MIT License
120 stars 20 forks source link

MIDI CCs being received on channel 16 #32

Closed tas-from-planet-u-he closed 1 year ago

tas-from-planet-u-he commented 1 year ago

Tested on macOS Monterey 12.6.1 with a 2020 M1 Silicon MacBook Pro using Bitwig 4.4.2.

It seems that all MIDI CC messages sent on any MIDI channel somehow end up in the wrapped plugin with MIDI channel 16 assigned.

Note from David: The underlying problem is that the MIDI CC1 (ModWheel) is being sent on channel 16. It appears to be a bug in the wrapper because Bitwig does send a ch1 CC1 correctly to our own VST3. The wrapper performs a lookup from ID to parameter index and the returned parameter happens to be on channel 16 (0x0f).

There are a number of issues, likely caused by this:

Ctrl A+B are simply two user defined MIDI CCs that can be used to modulate parameters via the plugin's mod matrix.

Pitch bend (PB) and mod wheel (MW) behaviour issue:

Using the mouse to adjust the graphical representation of pitch bend and md wheel works, the GUI elements move and the sound changes. Using the real physical PB and MW on the NI Komplete keyboard does not work correctly. The graphical MW does move in the GUI, but the sound does not change in Hive (this works ok in Repro). The graphical PB jumps to its lowest position and stays there, the sound does not change (same in Hive and Repro).

defiantnerd commented 1 year ago

fixed in next

tas-from-planet-u-he commented 1 year ago

Tested with current "next" branch. Tested with Hive 2 on M1 Mac with Monterey in Bitwig 4.4.3.

Mod wheel now working as expected. Ctrl A&B Feature working. Aftertouch is working. Sustain pedal working. MIDI CC assignment is using the correct MIDI channel.

There is still the issue with the pitch wheel, created a separate ticket for that, issue #37.