free-audio / clap-wrapper

Wrappers for using CLAP in other plugin environments
MIT License
123 stars 20 forks source link

Eject the CLAP features as AUv2 tags #325

Closed baconpaul closed 3 weeks ago

baconpaul commented 3 weeks ago

Addresses #324

defiantnerd commented 3 weeks ago

Looks fine - just a thought: should we make first character uppercase?

this is all lowercase: https://github.com/free-audio/clap/blob/27f20f81dec40b930d79ef429fd35dcc2d45db5b/include/clap/plugin-features.h#L39

and the Apple examples have first character uppercase.

what do you think?

baconpaul commented 3 weeks ago

Yeah I thought about that but my instinct was to not mess with them. But i think you are correct.

It's super easy to do an if a < tag[0] < z tag0 = topper tag0 and probably a smart choice.

Let me toss that in.

baconpaul commented 3 weeks ago

OK pushed.

Shortcircuit now gets

  <key>tags</key>
        <array>
          <string>Instrument</string>
          <string>Sampler</string>
          <string>Synthesizer</string>
          <string>Free and Open Source</string>
        </array>
      </dict>