free-audio / clap-wrapper

Wrappers for using CLAP in other plugin environments
MIT License
111 stars 18 forks source link

Parameters that represent a list should get the kIsList flag #89

Closed defiantnerd closed 7 months ago

defiantnerd commented 1 year ago

we need to check how much of the ParameterFlags for VST3 can be determined from the CLAP parameter definition:

enum ParameterFlags
  {
    kNoFlags = 0,       ///< no flags wanted
    kCanAutomate = 1 << 0,  ///< parameter can be automated
    kIsReadOnly = 1 << 1,   ///< parameter cannot be changed from outside the plug-in (implies that kCanAutomate is NOT set)
    kIsWrapAround = 1 << 2, ///< attempts to set the parameter value out of the limits will result in a wrap around [SDK 3.0.2]
    kIsList = 1 << 3,   ///< parameter should be displayed as list in generic editor or automation editing [SDK 3.1.0]
    kIsHidden = 1 << 4, ///< parameter should be NOT displayed and cannot be changed from outside the plug-in 
    ///< (implies that kCanAutomate is NOT set and kIsReadOnly is set) [SDK 3.7.0]

    kIsProgramChange = 1 << 15, ///< parameter is a program change (unitId gives info about associated unit 
    ///< - see \ref vst3ProgramLists)
    kIsBypass = 1 << 16 ///< special bypass parameter (only one allowed): plug-in can handle bypass
    ///< (highly recommended to export a bypass parameter for effect plug-in)
  };
baconpaul commented 1 year ago

Is this solved in next? I don't see a commit since I closed my PR.

defiantnerd commented 7 months ago

CLAP got the CLAP_PARAM_IS_ENUM flag and this will be tested to add kIsList to the parameter flags in VST3.

defiantnerd commented 7 months ago

added with CLAP 1.2.0 compatibility in 0.7.0 release